-
Notifications
You must be signed in to change notification settings - Fork 340
Remove whitelist settings in favor of allowlist #5224
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
willyborankin
merged 6 commits into
opensearch-project:main
from
shikharj05:depr-non-incl
Apr 1, 2025
Merged
Remove whitelist settings in favor of allowlist #5224
willyborankin
merged 6 commits into
opensearch-project:main
from
shikharj05:depr-non-incl
Apr 1, 2025
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: shikharj05 <8859327+shikharj05@users.noreply.github.com>
Signed-off-by: shikharj05 <8859327+shikharj05@users.noreply.github.com>
Signed-off-by: shikharj05 <8859327+shikharj05@users.noreply.github.com>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #5224 +/- ##
==========================================
- Coverage 71.70% 71.70% -0.01%
==========================================
Files 337 335 -2
Lines 22789 22736 -53
Branches 3606 3596 -10
==========================================
- Hits 16341 16302 -39
+ Misses 4650 4639 -11
+ Partials 1798 1795 -3
🚀 New features to boost your workflow:
|
Signed-off-by: shikharj05 <8859327+shikharj05@users.noreply.github.com>
12 tasks
cwperks
approved these changes
Apr 1, 2025
willyborankin
approved these changes
Apr 1, 2025
smortex
added a commit
to voxpupuli/puppet-opensearch
that referenced
this pull request
May 5, 2025
This repository has a GitHub action to maintain the default configuration of OpenSearch in sync with the upstream project. Upstream has removed its 'whitelist' settings in favor of the `allowlist` ones, which result in failure of the action to gather the default configuration: opensearch-project/security#5224 Adjust the update script so that the removed configuration is not looked for.
smortex
added a commit
to voxpupuli/puppet-opensearch
that referenced
this pull request
May 5, 2025
This repository has a GitHub action to maintain the default configuration of OpenSearch in sync with the upstream project. Upstream has removed its 'whitelist' settings in favor of the `allowlist` ones, which result in failure of the action to gather the default configuration: opensearch-project/security#5224 Adjust the update script so that the removed configuration is not looked for.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Maintenance
Removal of non-inclusive keywords from OpenSearch - https://opensearch.org/docs/latest/breaking-changes/#deprecate-non-inclusive-terms. Aligned with Change the "Blacklist / Whitelist" nomenclature OpenSearch#1483
Is this a backport? If so, please add backport PR # and/or commits #, and remove
backport-failedlabel from the original PR.Do these changes introduce new permission(s) to be displayed in the static dropdown on the front-end? If so, please open a draft PR in the security dashboards plugin and link the draft PR here
Testing
[Please provide details of testing done: unit testing, integration testing and manual testing]
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.