Skip to content

Conversation

@shikharj05
Copy link
Collaborator

Description

Is this a backport? If so, please add backport PR # and/or commits #, and remove backport-failed label from the original PR.

Do these changes introduce new permission(s) to be displayed in the static dropdown on the front-end? If so, please open a draft PR in the security dashboards plugin and link the draft PR here

Testing

[Please provide details of testing done: unit testing, integration testing and manual testing]

Check List

  • [] New functionality includes testing
  • New functionality has been documented
  • [NA] New Roles/Permissions have a corresponding security dashboards plugin PR
  • [NA] API changes companion pull request created
  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Signed-off-by: shikharj05 <8859327+shikharj05@users.noreply.github.com>
Signed-off-by: shikharj05 <8859327+shikharj05@users.noreply.github.com>
Signed-off-by: shikharj05 <8859327+shikharj05@users.noreply.github.com>
@codecov
Copy link

codecov bot commented Mar 28, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 71.70%. Comparing base (da21abf) to head (f0b91b3).

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #5224      +/-   ##
==========================================
- Coverage   71.70%   71.70%   -0.01%     
==========================================
  Files         337      335       -2     
  Lines       22789    22736      -53     
  Branches     3606     3596      -10     
==========================================
- Hits        16341    16302      -39     
+ Misses       4650     4639      -11     
+ Partials     1798     1795       -3     
Files with missing lines Coverage Δ
...ty/configuration/ConfigurationLoaderSecurity7.java 70.24% <100.00%> (ø)
...ecurity/configuration/ConfigurationRepository.java 79.84% <ø> (-0.08%) ⬇️
...rg/opensearch/security/dlic/rest/api/Endpoint.java 100.00% <ø> (ø)
...security/dlic/rest/api/SecurityRestApiActions.java 80.00% <ø> (ø)
...opensearch/security/filter/SecurityRestFilter.java 85.07% <100.00%> (-0.44%) ⬇️
...ch/security/securityconf/DynamicConfigFactory.java 62.32% <ø> (-0.18%) ⬇️
...g/opensearch/security/securityconf/impl/CType.java 93.02% <ø> (-0.16%) ⬇️
...nsearch/security/support/SecurityIndexHandler.java 93.39% <100.00%> (-0.13%) ⬇️
...a/org/opensearch/security/tools/SecurityAdmin.java 48.51% <ø> (+0.17%) ⬆️

... and 4 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Signed-off-by: shikharj05 <8859327+shikharj05@users.noreply.github.com>
@shikharj05 shikharj05 marked this pull request as ready for review March 28, 2025 18:10
@willyborankin willyborankin merged commit 7603dc2 into opensearch-project:main Apr 1, 2025
39 checks passed
@shikharj05 shikharj05 deleted the depr-non-incl branch April 1, 2025 19:25
smortex added a commit to voxpupuli/puppet-opensearch that referenced this pull request May 5, 2025
This repository has a GitHub action to maintain the default
configuration of OpenSearch in sync with the upstream project.

Upstream has removed its 'whitelist' settings in favor of the
`allowlist` ones, which result in failure of the action to gather the
default configuration:
opensearch-project/security#5224

Adjust the update script so that the removed configuration is not looked
for.
smortex added a commit to voxpupuli/puppet-opensearch that referenced this pull request May 5, 2025
This repository has a GitHub action to maintain the default
configuration of OpenSearch in sync with the upstream project.

Upstream has removed its 'whitelist' settings in favor of the
`allowlist` ones, which result in failure of the action to gather the
default configuration:
opensearch-project/security#5224

Adjust the update script so that the removed configuration is not looked
for.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants