Skip to content

Conversation

@cwperks
Copy link
Member

@cwperks cwperks commented Feb 25, 2025

Description

Upgrade kafka_version from 3.7.1 to 4.0.0

  • Category (Enhancement, New feature, Bug fix, Test fix, Refactoring, Maintenance, Documentation)

Maintenance

Issues Resolved

Attempt to update these dependencies. Seeing failing tests from the kafka update in separate PR: #4888

Check List

  • New functionality includes testing
  • New functionality has been documented
  • New Roles/Permissions have a corresponding security dashboards plugin PR
  • API changes companion pull request created
  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

…7.1 to 3.9.0 on main

Signed-off-by: Craig Perkins <cwperx@amazon.com>
@cwperks cwperks closed this Feb 25, 2025
@cwperks cwperks reopened this Mar 25, 2025
@cwperks cwperks changed the title Upgrade spring_version from 5.3.39 to 6.2.3 and kafka_version from 3.7.1 to 3.9.0 on main Upgrade kafka_version from 3.7.1 to 3.9.0 on main Mar 25, 2025
@cwperks cwperks closed this Mar 25, 2025
@cwperks cwperks reopened this May 19, 2025
Signed-off-by: Craig Perkins <cwperx@amazon.com>
@cwperks cwperks changed the title Upgrade kafka_version from 3.7.1 to 3.9.0 on main Upgrade kafka_version from 3.7.1 to 4.0.0 May 19, 2025
cwperks added 3 commits May 19, 2025 15:39
Signed-off-by: Craig Perkins <cwperx@amazon.com>
Signed-off-by: Craig Perkins <cwperx@amazon.com>
Signed-off-by: Craig Perkins <cwperx@amazon.com>
@codecov
Copy link

codecov bot commented May 19, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 71.92%. Comparing base (d7435f0) to head (7297ff4).
Report is 3 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #5131      +/-   ##
==========================================
+ Coverage   71.90%   71.92%   +0.02%     
==========================================
  Files         378      378              
  Lines       23562    23562              
  Branches     3630     3630              
==========================================
+ Hits        16942    16948       +6     
+ Misses       4810     4803       -7     
- Partials     1810     1811       +1     

see 8 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@cwperks cwperks marked this pull request as ready for review May 20, 2025 00:59
Copy link
Collaborator

@nibix nibix left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving this.

Yet, this is likely a change without consequences, as the Kafka audit log sink cannot be actually used (and - if I am informed correctly - never could be so far).

See:

However, audit logs can be configured to log to log4j which in turn can log to Kafka.

Maybe, for code hygiene and maintenance reasons, it might make sense to remove the Kafka dependency?

@cwperks
Copy link
Member Author

cwperks commented May 20, 2025

Maybe, for code hygiene and maintenance reasons, it might make sense to remove the Kafka dependency?

I have not seen any forum posts or Github issues about kafka support so it should be ok to remove if its non-functional.

What would be required to make this function? One concern with re-using log4j as a sink is that it would get interleaved with application logs vs directly posting to kafka.

@cwperks cwperks merged commit 344673a into opensearch-project:main May 20, 2025
56 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants