-
Couldn't load subscription status.
- Fork 337
Upgrade kafka_version from 3.7.1 to 4.0.0 #5131
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
…7.1 to 3.9.0 on main Signed-off-by: Craig Perkins <cwperx@amazon.com>
Signed-off-by: Craig Perkins <cwperx@amazon.com>
Signed-off-by: Craig Perkins <cwperx@amazon.com>
Signed-off-by: Craig Perkins <cwperx@amazon.com>
Signed-off-by: Craig Perkins <cwperx@amazon.com>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #5131 +/- ##
==========================================
+ Coverage 71.90% 71.92% +0.02%
==========================================
Files 378 378
Lines 23562 23562
Branches 3630 3630
==========================================
+ Hits 16942 16948 +6
+ Misses 4810 4803 -7
- Partials 1810 1811 +1 🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approving this.
Yet, this is likely a change without consequences, as the Kafka audit log sink cannot be actually used (and - if I am informed correctly - never could be so far).
See:
- Issue: #4373
- The docs also do not mention a Kafka sink: https://docs.opensearch.org/docs/latest/security/audit-logs/storage-types/
However, audit logs can be configured to log to log4j which in turn can log to Kafka.
Maybe, for code hygiene and maintenance reasons, it might make sense to remove the Kafka dependency?
What would be required to make this function? One concern with re-using log4j as a sink is that it would get interleaved with application logs vs directly posting to kafka. |
Description
Upgrade kafka_version from 3.7.1 to 4.0.0
Maintenance
Issues Resolved
Attempt to update these dependencies. Seeing failing tests from the kafka update in separate PR: #4888
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.