Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Backport 2.x] Ensure that dual mode enabled flag from cluster settings can get propagated to core #4830

Merged
merged 1 commit into from
Oct 21, 2024

Conversation

opensearch-trigger-bot[bot]
Copy link
Contributor

Backport 811f26d from #4820.

…agated to core (#4820)

Signed-off-by: Craig Perkins <cwperx@amazon.com>
(cherry picked from commit 811f26d)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Copy link

codecov bot commented Oct 21, 2024

Codecov Report

Attention: Patch coverage is 83.33333% with 1 line in your changes missing coverage. Please review.

Project coverage is 64.60%. Comparing base (5902191) to head (f4f50fc).
Report is 5 commits behind head on 2.x.

Files with missing lines Patch % Lines
...arch/security/ssl/OpenSearchSecuritySSLPlugin.java 0.00% 1 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##              2.x    #4830      +/-   ##
==========================================
- Coverage   64.66%   64.60%   -0.07%     
==========================================
  Files         320      320              
  Lines       22372    22384      +12     
  Branches     3611     3616       +5     
==========================================
- Hits        14467    14461       -6     
- Misses       6127     6140      +13     
- Partials     1778     1783       +5     
Files with missing lines Coverage Δ
.../opensearch/security/OpenSearchSecurityPlugin.java 84.88% <100.00%> (+0.02%) ⬆️
.../security/ssl/OpenSearchSecureSettingsFactory.java 81.25% <100.00%> (+1.93%) ⬆️
...arch/security/ssl/OpenSearchSecuritySSLPlugin.java 86.30% <0.00%> (ø)

... and 5 files with indirect coverage changes

@derek-ho derek-ho merged commit a343a9b into 2.x Oct 21, 2024
90 of 91 checks passed
@derek-ho derek-ho deleted the backport/backport-4820-to-2.x branch October 21, 2024 18:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants