Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Backport 2.17] changing comments permission for alerting_ack_alerts role #4724

Merged
merged 1 commit into from
Sep 9, 2024
Merged

[Backport 2.17] changing comments permission for alerting_ack_alerts role #4724

merged 1 commit into from
Sep 9, 2024

Conversation

opensearch-trigger-bot[bot]
Copy link
Contributor

Backport f9107b8 from #4709.

@github-actions @toepkerd-zz
changing comments permission for alerting_ack_alerts role (#4709)
19c02f4 
Signed-off-by: Dennis Toepker <toepkerd@amazon.com>
Co-authored-by: Dennis Toepker <toepkerd@amazon.com>
(cherry picked from commit f9107b8)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
@cwperks cwperks merged commit 1951345 into 2.17 Sep 9, 2024
87 checks passed
@cwperks cwperks deleted the backport/backport-4709-to-2.17 branch September 9, 2024 23:37
@codecov Codecov
Copy link

codecov bot commented Sep 9, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 65.33%. Comparing base (d43de79) to head (19c02f4).
Report is 3 commits behind head on 2.17.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             2.17    #4724      +/-   ##
==========================================
- Coverage   65.36%   65.33%   -0.04%     
==========================================
  Files         317      317              
  Lines       22158    22158              
  Branches     3581     3581              
==========================================
- Hits        14484    14476       -8     
- Misses       5878     5887       +9     
+ Partials     1796     1795       -1

see 2 files with indirect coverage changes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cwperks cwperks cwperks approved these changes

@RyanL1997 RyanL1997 RyanL1997 approved these changes

@DarshitChanpura DarshitChanpura Awaiting requested review from DarshitChanpura DarshitChanpura is a code owner

@nibix nibix Awaiting requested review from nibix nibix is a code owner

@peternied peternied Awaiting requested review from peternied peternied is a code owner

@stephen-crawford stephen-crawford Awaiting requested review from stephen-crawford

@reta reta Awaiting requested review from reta reta is a code owner

@willyborankin willyborankin Awaiting requested review from willyborankin willyborankin is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@cwperks @RyanL1997