Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "Fix covereage-report workflow (#4683)" #4686

Merged
merged 1 commit into from
Aug 28, 2024

Conversation

cwperks
Copy link
Member

@cwperks cwperks commented Aug 27, 2024

This reverts commit 359272e.

Description

This PR reverts a previous change that purportedly fixed the codecov-report CI check. After the PR was merged into main, I observed that the fix was not working as intended and had a false sense of fix because codecov upload works with tokenless uploads on forks.

While the change is a valid way to configure codecov/codecov-action@v4 according to the README, there is an issue with the usage of env inside the Wandalen/wretry.action@v3.5.0 action which is an action that automatically retries upload on failure.

Warning: Unexpected input(s) 'env', valid inputs are ['action', 'command', 'with', 'current_path', 'steps_context', 'attempt_limit', 'attempt_delay', 'time_out', 'retry_condition', 'github_token']

ref: https://github.com/opensearch-project/security/actions/runs/10561243044/job/29257710874

Initially, I made the PR because this check failed on 3 dependabot PRs:

It turns out, the issue is specific to dependabot. Dependabot does not have access to the secrets of the repo and a separate section with Dependabot Secrets needs to be populated.

This change should be reverted and the CODECOV_TOKEN should be added to the repo as a Dependabot Secret

  • Category (Enhancement, New feature, Bug fix, Test fix, Refactoring, Maintenance, Documentation)

Maintenance

Check List

  • New functionality includes testing
  • New functionality has been documented
  • New Roles/Permissions have a corresponding security dashboards plugin PR
  • API changes companion pull request created
  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

This reverts commit 359272e.

Signed-off-by: Craig Perkins <cwperx@amazon.com>
Copy link

codecov bot commented Aug 27, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 65.21%. Comparing base (0b66f48) to head (384a8d0).
Report is 3 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #4686      +/-   ##
==========================================
- Coverage   65.26%   65.21%   -0.05%     
==========================================
  Files         317      317              
  Lines       22320    22320              
  Branches     3591     3591              
==========================================
- Hits        14568    14557      -11     
- Misses       5953     5964      +11     
  Partials     1799     1799              

see 3 files with indirect coverage changes

@cwperks cwperks added the backport 2.x backport to 2.x branch label Aug 28, 2024
@cwperks cwperks merged commit dd74bdb into opensearch-project:main Aug 28, 2024
42 of 43 checks passed
opensearch-trigger-bot bot pushed a commit that referenced this pull request Aug 28, 2024
Signed-off-by: Craig Perkins <cwperx@amazon.com>
(cherry picked from commit dd74bdb)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport 2.x backport to 2.x branch
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants