Skip to content

Conversation

@peternied
Copy link
Member

Description

This change will prevent new clusters from using the 'custom serialization' format that was causing performance impact with customers in OpenSearch 2.11.

Background: the serialization changes from #2802 introduced issues where for certain serialization headers that were previously very small for over the wire transmission become much larger. The root cause of this was that the JDK serialization process was able to detect duplicate entries and then use an encoding format to make it compressible. Adding this logic into the serialization system from OpenSearch is non-trivial and is not being invested in.

Issues Resolved

Testing

BWC test should cover the scenarios
Before leaving draft, going to build tests that verify larger thread constructors are serialized in a compatible way.

Check List

  • New functionality includes testing
  • New functionality has been documented
  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Signed-off-by: Peter Nied <petern@amazon.com>
Signed-off-by: Peter Nied <petern@amazon.com>
…ilzer

Signed-off-by: Peter Nied <petern@amazon.com>
Signed-off-by: Peter Nied <petern@amazon.com>
Signed-off-by: Peter Nied <petern@amazon.com>
@peternied peternied marked this pull request as ready for review April 24, 2024 21:08
@codecov
Copy link

codecov bot commented Apr 24, 2024

Codecov Report

Attention: Patch coverage is 90.90909% with 2 lines in your changes are missing coverage. Please review.

Project coverage is 66.08%. Comparing base (c09fad5) to head (dfc96ae).
Report is 1 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #4264      +/-   ##
==========================================
+ Coverage   66.06%   66.08%   +0.01%     
==========================================
  Files         301      302       +1     
  Lines       21711    21723      +12     
  Branches     3506     3509       +3     
==========================================
+ Hits        14343    14355      +12     
- Misses       5607     5609       +2     
+ Partials     1761     1759       -2     
Files Coverage Δ
...urity/ssl/transport/SecuritySSLRequestHandler.java 71.95% <100.00%> (ø)
...g/opensearch/security/support/ConfigConstants.java 95.00% <ø> (-0.24%) ⬇️
...ensearch/security/support/SerializationFormat.java 100.00% <100.00%> (ø)
...search/security/transport/SecurityInterceptor.java 79.76% <83.33%> (+1.10%) ⬆️

... and 6 files with indirect coverage changes

@peternied
Copy link
Member Author

Note; BWC tests are failing because 2.14 needs the updated behavior - making the change directly in #4288

@peternied
Copy link
Member Author

@DarshitChanpura @scrawfor99 Mind taking a look at this version of the change, nearly the same as #4288

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Introduce Environment variable for choosing serialisation - JDK or custom [BUG] DLS performance has regressed with new serialization format

4 participants