[Backport 2.x] Regenerates root-ca, kirk and esnode certificates to address already expired root ca certificate #4066
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…expired root ca certificate (#4061) ### Description During the last renewal of certs #3268, the option `-days 3650` was missed for root-ca.pem cert causing it to set the default expiry of 30 days. This PR regenerates the public cert root-ca.pem, using the same private-key, and it also regenerate public certs `es-node.pem` and `kirk.pem` so that they can be verified with this new certificate. * Category : Bug fix * Why these changes are required? - To ensure the expiry is in 10 years from now * What is the old behavior before changes and new behavior after changes? - root-ca is currently expired, and this change will set expiry to 2034 ### Issues Resolved - Resolves #4047 ### Testing - Automated testing + [Manual Testing](#4061 (comment)) --------- Signed-off-by: Darshit Chanpura <dchanp@amazon.com> (cherry picked from commit 9a6a018) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
opensearch-trigger-bot
bot
requested review from
DarshitChanpura,
RyanL1997,
cliu123,
cwperks,
davidlago,
peternied,
reta,
stephen-crawford and
willyborankin
as code owners
DarshitChanpura
approved these changes
Feb 22, 2024
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## 2.x #4066 +/- ##
==========================================
+ Coverage 65.70% 65.73% +0.02%
==========================================
Files 297 297
Lines 21094 21097 +3
Branches 3453 3453
==========================================
+ Hits 13860 13868 +8
+ Misses 5508 5502 -6
- Partials 1726 1727 +1
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport 9a6a018 from #4061.