Change log message from warning to trace on WWW-Authenticate challenge #3364
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bagipriyank
requested review from
DarshitChanpura,
RyanL1997,
cliu123,
cwperks,
davidlago,
peternied,
reta,
stephen-crawford and
willyborankin
as code owners
bagipriyank
force-pushed
the
issue-3273
branch
from
a96cefd to
5ec40e6
Compare
peternied
changed the title
peternied
previously approved these changes
Sep 15, 2023
|
Note; I've cleaned up the pull request title and description. |
Codecov Report
@@ Coverage Diff @@
## main #3364 +/- ##
============================================
- Coverage 64.17% 64.16% -0.01%
Complexity 3472 3472
============================================
Files 263 263
Lines 20112 20113 +1
Branches 3359 3360 +1
============================================
- Hits 12907 12906 -1
- Misses 5526 5527 +1
- Partials 1679 1680 +1
|
added 2 commits
September 15, 2023 13:13
…n' header, send 401 and 'WWW-Authenticate Basic' to trace Signed-off-by: Priyank Bagrecha <pbagrecha@roku.com>
bagipriyank
force-pushed
the
issue-3273
branch
from
1d827ea to
fd74e1d
Compare
peternied
approved these changes
Sep 19, 2023
stephen-crawford
approved these changes
Sep 19, 2023
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Oct 3, 2023
#3364) ### Description Change warning message No 'Basic Authorization' header, send 401 and 'WWW-Authenticate Basic' to trace ### Issues Resolved - Resolves #3273 ### Check List - [ ] New functionality includes testing - [ ] New functionality has been documented - [X] Commits are signed per the DCO using --signoff By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license. For more information on following Developer Certificate of Origin and signing off your commits, please check [here](https://github.com/opensearch-project/OpenSearch/blob/main/CONTRIBUTING.md#developer-certificate-of-origin). --------- Signed-off-by: Priyank Bagrecha <pbagrecha@roku.com> Co-authored-by: Priyank Bagrecha <pbagrecha@roku.com> (cherry picked from commit a41638b) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
DarshitChanpura
pushed a commit
that referenced
this pull request
Oct 3, 2023
…ticate challenge (#3446) Backport a41638b from #3364. Signed-off-by: Priyank Bagrecha <pbagrecha@roku.com> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: Priyank Bagrecha <pbagrecha@roku.com>
Closed
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Change warning message No 'Basic Authorization' header, send 401 and 'WWW-Authenticate Basic' to trace
Issues Resolved
No 'Basic Authorization' header, send 401 and 'WWW-Authenticate Basic'in log #3273Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.