Skip to content

Conversation

@cwperks
Copy link
Member

@cwperks cwperks commented Jun 8, 2023

Description

Changes an assertion in JwtAuthenticationTests.shouldAuthenticateWithJwtToken_positive that was not testing the code correctly. It was checking if a variable was equal to itself instead of the actual expected value.

  • Category (Enhancement, New feature, Bug fix, Test fix, Refactoring, Maintenance, Documentation)

Test fix

Testing

./gradlew integrationTest --tests JwtAuthenticationTests -i

Check List

  • New functionality includes testing
  • New functionality has been documented
  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Signed-off-by: Craig Perkins <cwperx@amazon.com>
@cwperks
Copy link
Member Author

cwperks commented Jun 8, 2023

Caused by: java.lang.NoClassDefFoundError: org/opensearch/core/common/lease/Releasable

Looking into this error

@codecov
Copy link

codecov bot commented Jun 8, 2023

Codecov Report

Merging #2844 (1af9a68) into main (ceb5ad2) will decrease coverage by 0.02%.
The diff coverage is n/a.

@@             Coverage Diff              @@
##               main    #2844      +/-   ##
============================================
- Coverage     61.60%   61.59%   -0.02%     
+ Complexity     3414     3412       -2     
============================================
  Files           266      266              
  Lines         18917    18917              
  Branches       3303     3303              
============================================
- Hits          11653    11651       -2     
  Misses         5669     5669              
- Partials       1595     1597       +2     

see 2 files with indirect coverage changes

@stephen-crawford
Copy link
Contributor

Caused by: java.lang.NoClassDefFoundError: org/opensearch/core/common/lease/Releasable

Looking into this error

Hey @cwperks, the error is related to this change: opensearch-project/OpenSearch#7646

@cwperks cwperks merged commit 7e8acd4 into opensearch-project:main Jun 13, 2023
RyanL1997 pushed a commit to RyanL1997/security that referenced this pull request Jun 13, 2023
Signed-off-by: Craig Perkins <cwperx@amazon.com>
samuelcostae pushed a commit to samuelcostae/security that referenced this pull request Jun 19, 2023
Signed-off-by: Craig Perkins <cwperx@amazon.com>
samuelcostae pushed a commit to samuelcostae/security that referenced this pull request Jun 19, 2023
Signed-off-by: Craig Perkins <cwperx@amazon.com>
Signed-off-by: Sam <samuel.costa@eliatra.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants