Skip to content

Conversation

@sbcd90
Copy link
Contributor

@sbcd90 sbcd90 commented May 3, 2023

Description

update security-analytics roles to add correlation engine apis

  • Category (Enhancement)
  • Why these changes are required?
  • What is the old behavior before changes and new behavior after changes?

Issues Resolved

[List any issues this PR will resolve]

Is this a backport? If so, please add backport PR # and/or commits #

Testing

[Please provide details of testing done: unit testing, integration testing and manual testing]

Check List

  • New functionality includes testing
  • New functionality has been documented
  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Copy link
Member

@peternied peternied left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please make the changes to the roles in alphabetical order so its easier for a administrator to read

@codecov-commenter
Copy link

Codecov Report

Merging #2732 (ccdd782) into main (a5489a2) will decrease coverage by 0.04%.
The diff coverage is n/a.

📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

@@             Coverage Diff              @@
##               main    #2732      +/-   ##
============================================
- Coverage     61.51%   61.47%   -0.04%     
+ Complexity     3396     3392       -4     
============================================
  Files           272      272              
  Lines         18740    18740              
  Branches       3284     3284              
============================================
- Hits          11528    11521       -7     
- Misses         5613     5616       +3     
- Partials       1599     1603       +4     

see 2 files with indirect coverage changes

Signed-off-by: Subhobrata Dey <sbcd90@gmail.com>
@sbcd90
Copy link
Contributor Author

sbcd90 commented May 3, 2023

Please make the changes to the roles in alphabetical order so its easier for a administrator to read

hi @peternied , made changes as per your suggestions.

@DarshitChanpura DarshitChanpura merged commit 14bb8a3 into opensearch-project:main May 3, 2023
opensearch-trigger-bot bot pushed a commit that referenced this pull request May 3, 2023
Signed-off-by: Subhobrata Dey <sbcd90@gmail.com>
(cherry picked from commit 14bb8a3)
cwperks pushed a commit that referenced this pull request May 15, 2023
#2735)

Signed-off-by: Subhobrata Dey <sbcd90@gmail.com>
(cherry picked from commit 14bb8a3)

Co-authored-by: Subhobrata Dey <sbcd90@gmail.com>
stephen-crawford pushed a commit to stephen-crawford/security that referenced this pull request May 16, 2023
…earch-project#2732) (opensearch-project#2735)

Signed-off-by: Subhobrata Dey <sbcd90@gmail.com>
(cherry picked from commit 14bb8a3)

Co-authored-by: Subhobrata Dey <sbcd90@gmail.com>
sebastianmichalski pushed a commit to sebastianmichalski/security that referenced this pull request May 19, 2023
MaciejMierzwa pushed a commit to MaciejMierzwa/security that referenced this pull request Jun 13, 2023
…earch-project#2732)

Signed-off-by: Subhobrata Dey <sbcd90@gmail.com>
Signed-off-by: Maciej Mierzwa <dev.maciej.mierzwa@gmail.com>
MaciejMierzwa pushed a commit to MaciejMierzwa/security that referenced this pull request Jun 13, 2023
…earch-project#2732)

Signed-off-by: Subhobrata Dey <sbcd90@gmail.com>
Signed-off-by: Maciej Mierzwa <dev.maciej.mierzwa@gmail.com>
samuelcostae pushed a commit to samuelcostae/security that referenced this pull request Jun 19, 2023
…earch-project#2732)

Signed-off-by: Subhobrata Dey <sbcd90@gmail.com>
Signed-off-by: Sam <samuel.costa@eliatra.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants