Revert "Updates toString calls affected by change in method signature" #2460
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Craig Perkins <cwperx@amazon.com>
RyanL1997
approved these changes
Feb 22, 2023
Codecov Report
📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more @@ Coverage Diff @@
## 2.6 #2460 +/- ##
======================================
Coverage ? 61.00%
Complexity ? 3246
======================================
Files ? 258
Lines ? 18130
Branches ? 3231
======================================
Hits ? 11060
Misses ? 5494
Partials ? 1576 Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
|
Merging this now as all checks, but MacOS have succeeded. MacOS is not required and has been removed on main. |
wuychn
pushed a commit
to ochprince/security
that referenced
this pull request
Mar 16, 2023
…pensearch-project#2460) Signed-off-by: Craig Perkins <cwperx@amazon.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Reverts #2452 in response to the reversion from core (opensearch-project/OpenSearch#6431).
This retains the change in 2.x, but reverts for 2.6.
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.