Skip to content

Conversation

@raj-chak
Copy link
Contributor

@raj-chak raj-chak commented Nov 2, 2022

  • roles yml changes for security-analytics plugin

Signed-off-by: Raj Chakravarthi raj@icedome.ca
Signed-off-by: Raj Chakravarthi 49325334+raj-chak@users.noreply.github.com
(cherry picked from commit 89a11c5)

Description

[Describe what this change achieves]

  • Category (Enhancement, New feature, Bug fix, Test fix, Refactoring, Maintenance, Documentation)
  • Why these changes are required?
  • What is the old behavior before changes and new behavior after changes?

Issues Resolved

[List any issues this PR will resolve]

Is this a backport? If so, please add backport PR # and/or commits #

Testing

[Please provide details of testing done: unit testing, integration testing and manual testing]

Check List

  • New functionality includes testing
  • New functionality has been documented
  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

)

* roles yml changes for security-analytics plugin

Signed-off-by: Raj Chakravarthi <raj@icedome.ca>
Signed-off-by: Raj Chakravarthi <49325334+raj-chak@users.noreply.github.com>
(cherry picked from commit 89a11c5)
@raj-chak raj-chak requested a review from a team November 2, 2022 22:58
@codecov-commenter
Copy link

codecov-commenter commented Nov 2, 2022

Codecov Report

Merging #2225 (8834cd2) into 2.4 (2a1e7d7) will decrease coverage by 0.03%.
The diff coverage is n/a.

@@             Coverage Diff              @@
##                2.4    #2225      +/-   ##
============================================
- Coverage     61.06%   61.02%   -0.04%     
+ Complexity     3250     3246       -4     
============================================
  Files           258      258              
  Lines         18123    18123              
  Branches       3231     3231              
============================================
- Hits          11066    11059       -7     
- Misses         5485     5492       +7     
  Partials       1572     1572              
Impacted Files Coverage Δ
...ecurity/configuration/ConfigurationRepository.java 72.13% <0.00%> (-2.19%) ⬇️
.../dlic/auth/ldap2/LDAPConnectionFactoryFactory.java 57.46% <0.00%> (-1.50%) ⬇️
...iance/ComplianceIndexingOperationListenerImpl.java 61.76% <0.00%> (-1.48%) ⬇️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@peternied peternied changed the title roles yml changes for security-analytics plugin (#2192) [Backport 2.4] roles yml changes for security-analytics plugin (#2192) Nov 3, 2022
@peternied
Copy link
Member

Resolved the merge conflict and retriggered CI.

Created the following issue to deal with the unreliable test case

@peternied peternied merged commit 4533c8c into opensearch-project:2.4 Nov 3, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants