Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Testing] Enhance sanity testing framework #3530

Closed
2 tasks done
DarshitChanpura opened this issue Oct 11, 2023 · 9 comments
Closed
2 tasks done

[Testing] Enhance sanity testing framework #3530

DarshitChanpura opened this issue Oct 11, 2023 · 9 comments
Assignees
Labels
enhancement New feature or request triaged Issues labeled as 'Triaged' have been reviewed and are deemed actionable.

Comments

@DarshitChanpura
Copy link
Member

DarshitChanpura commented Oct 11, 2023

As part of initial effort, sanity tests were added to verify whether security plugin was installed correctly. With that in place, this issue proposes addition of a series of tests that run with :integTestRemote and the intent is to automate tests performed manually after every release.
These tests will run in every CI run as well as when distribution builds are being invoked. These tests will also help keep healthy check on whether incoming changes change security plugin behavior.

Here is the runbook for the tests:
sanity-testing-runbook.txt

Exit criteria:

  • Ensure all tests are written in security plugin (Translate these scenarios into individual tests)
  • Analyze all steps and implement tests required in security-dashboards-plugin. (enhance tests covered in functional test repo)
@DarshitChanpura DarshitChanpura added the enhancement New feature or request label Oct 11, 2023
@github-actions github-actions bot added the untriaged Require the attention of the repository maintainers and may need to be prioritized label Oct 11, 2023
@stephen-crawford
Copy link
Contributor

[Triage] Hi @DarshitChanpura, thank you for filing this issue. More testing is always helpful and this has clear steps. Marking as triaged.

@stephen-crawford stephen-crawford added triaged Issues labeled as 'Triaged' have been reviewed and are deemed actionable. and removed untriaged Require the attention of the repository maintainers and may need to be prioritized labels Oct 16, 2023
@samuelcostae
Copy link
Contributor

Gonna start looking into this

@samuelcostae
Copy link
Contributor

@DarshitChanpura the existing tests make use of a number mock API Calls. I would like to confirm that for the scope this issue we don't want to use these mocks(For the main calls at least) so we can sanity check both OSS Plugin and OSS Dashboards Plugin. Is that correct?

@samuelcostae
Copy link
Contributor

@DarshitChanpura Another question, in the text file with the steps. the section "Dashboards Basics", it mentions opening the browser in incognito mode and check if the data is correct. The incognito part made me not sure if that sections another set of tests, or its a manual verifcation that i should do now to check if the tests are working as expected.

@DarshitChanpura
Copy link
Member Author

the existing tests make use of a number mock API Calls. I would like to confirm that for the scope this issue we don't want to use these mocks(For the main calls at least) so we can sanity check both OSS Plugin and OSS Dashboards Plugin. Is that correct?

We would like to replicate the steps as test. They are all mostly for front-end (jest_integration). The API calls should be translated to tests on the backend (we can utilize the test framework to do so)

Another question, in the text file with the steps. the section "Dashboards Basics", it mentions opening the browser in incognito mode and check if the data is correct. The incognito part made me not sure if that sections another set of tests, or its a manual verifcation that i should do now to check if the tests are working as expected.

your observation is correct. It's manual verification by logging in as another user to verify that the action was successful.

@peternied
Copy link
Member

@DarshitChanpura Its been a while since there have been updates on this issue, can you check where this is at?

@DarshitChanpura
Copy link
Member Author

DarshitChanpura commented Jan 18, 2024

Here is the PR from @samuelcostae : opensearch-project/opensearch-dashboards-functional-test#958 to add tests from the runbook

@DarshitChanpura
Copy link
Member Author

This issue is currently blocked awaiting review from maintainers of the functional tests repo.

@DarshitChanpura
Copy link
Member Author

Closed as completed via: opensearch-project/opensearch-dashboards-functional-test#958

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request triaged Issues labeled as 'Triaged' have been reviewed and are deemed actionable.
Projects
None yet
Development

No branches or pull requests

4 participants