#3530 enhance sanity testing framework #958
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Sam <samuel.costa@eliatra.com>
Signed-off-by: Sam <samuel.costa@eliatra.com>
samuelcostae
force-pushed
the
#3530_Enhance_sanity_testing_framework
branch
from
1060c69
to
03187b8
Compare
Signed-off-by: Sam <samuel.costa@eliatra.com>
Signed-off-by: Sam <samuel.costa@eliatra.com>
Signed-off-by: Sam <samuel.costa@eliatra.com>
samuelcostae
requested review from
xluo-aws,
Hailong-am,
SuZhou-Joe,
ruanyl,
wanglam and
raintygao
as code owners
samuelcostae
changed the title
|
@DarshitChanpura the tests are basically done, but based on the clarification on the issue discussion, i still have to replace the actual calls to the backend with mock responses. I'm moving this out of draft without having complete that step I can get any feedback on the overall structure of the tests |
SuZhou-Joe
reviewed
Dec 1, 2023
cypress/integration/plugins/security-dashboards-plugin/sanity_tests.spec.js
Outdated
Show resolved
Hide resolved
SuZhou-Joe
reviewed
Dec 1, 2023
cypress/integration/plugins/security-dashboards-plugin/sanity_tests.spec.js
Outdated
Show resolved
Hide resolved
SuZhou-Joe
reviewed
Dec 1, 2023
cypress/integration/plugins/security-dashboards-plugin/sanity_tests.spec.js
Outdated
Show resolved
Hide resolved
SuZhou-Joe
reviewed
Dec 1, 2023
cypress/integration/plugins/security-dashboards-plugin/sanity_tests.spec.js
Outdated
Show resolved
Hide resolved
samuelcostae
force-pushed
the
#3530_Enhance_sanity_testing_framework
branch
from
b1d4517
to
f28dba4
Compare
|
@DarshitChanpura can you review this and let me know your thoughts? thanks |
|
@DarshitChanpura friendly ping |
|
Could we get some maintainer reviews on this? In the latest CI run, cy.wait didn't seem to have caused any issues |
2 tasks
|
@samuelcostae should this backport to |
yes. |
|
@SuZhou-Joe @xluo-aws @Hailong-am @ruanyl @wanglam @raintygao Can we get some reviews on this PR? Last update was more than a month ago. |
Hailong-am
reviewed
Mar 6, 2024
cypress/integration/plugins/security-dashboards-plugin/sanity_tests.spec.js
Outdated
Show resolved
Hide resolved
cypress/integration/plugins/security-dashboards-plugin/sanity_tests.spec.js
Show resolved
Hide resolved
Check if pattern was acually created Signed-off-by: Sam <samuel.costa@eliatra.com>
…mework' into #3530_Enhance_sanity_testing_framework
Hailong-am
approved these changes
Mar 8, 2024
|
@samuelcostae would you mind paste local run result? The CI flow not running for the security-dashbaord-plugin and create an issue to track #1139 |
|
|
@SuZhou-Joe @xluo-aws @ruanyl @wanglam @raintygao Can we get 1 more review on this PR? |
|
@SuZhou-Joe @xluo-aws @ruanyl @wanglam @raintygao Can we get 1 more review on this PR please? |
|
@davidlago @wbeckler can you please help get this unblocked? |
@davidlago @wbeckler Just a friendly ping for a second review. Let us know any further work is required. |
|
@SuZhou-Joe @xluo-aws @ruanyl @wanglam @raintygao Pinging for 1 more review on this PR please. |
|
@SuZhou-Joe @xluo-aws @ruanyl @wanglam @raintygao Pinging for 1 more review on this PR please. This has been lingering for more than 2 weeks now. |
ruanyl
approved these changes
Mar 28, 2024
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Mar 28, 2024
* initial skeleton Signed-off-by: Sam <samuel.costa@eliatra.com> * first two sections Signed-off-by: Sam <samuel.costa@eliatra.com> * first two sections Signed-off-by: Sam <samuel.costa@eliatra.com> * index pattern creation Signed-off-by: Sam <samuel.costa@eliatra.com> * index pattern creation Signed-off-by: Sam <samuel.costa@eliatra.com> * Bug Fixes Signed-off-by: Sam <samuel.costa@eliatra.com> * Cleanup Signed-off-by: Sam <samuel.costa@eliatra.com> * Cleanup Signed-off-by: Sam <samuel.costa@eliatra.com> * Cleanup Signed-off-by: Sam <samuel.costa@eliatra.com> * Refactor Signed-off-by: Sam <samuel.costa@eliatra.com> * Comment/ Extra line removal Signed-off-by: Sam <samuel.costa@eliatra.com> * Using loadSampleData command instead of custom method. Check if pattern was acually created Signed-off-by: Sam <samuel.costa@eliatra.com> --------- Signed-off-by: Sam <samuel.costa@eliatra.com> (cherry picked from commit e1e0716)
|
One comment is that we should consider on cleaning up the addition of the sample data within the test itself. Otherwise it leaves the cluster in a dirty state and could case the next test to fail. I would also verify that the expected test index isn't already existing to avoid transient failures. |
SuZhou-Joe
pushed a commit
that referenced
this pull request
Apr 30, 2024
* initial skeleton Signed-off-by: Sam <samuel.costa@eliatra.com> * first two sections Signed-off-by: Sam <samuel.costa@eliatra.com> * first two sections Signed-off-by: Sam <samuel.costa@eliatra.com> * index pattern creation Signed-off-by: Sam <samuel.costa@eliatra.com> * index pattern creation Signed-off-by: Sam <samuel.costa@eliatra.com> * Bug Fixes Signed-off-by: Sam <samuel.costa@eliatra.com> * Cleanup Signed-off-by: Sam <samuel.costa@eliatra.com> * Cleanup Signed-off-by: Sam <samuel.costa@eliatra.com> * Cleanup Signed-off-by: Sam <samuel.costa@eliatra.com> * Refactor Signed-off-by: Sam <samuel.costa@eliatra.com> * Comment/ Extra line removal Signed-off-by: Sam <samuel.costa@eliatra.com> * Using loadSampleData command instead of custom method. Check if pattern was acually created Signed-off-by: Sam <samuel.costa@eliatra.com> --------- Signed-off-by: Sam <samuel.costa@eliatra.com> (cherry picked from commit e1e0716)
LDrago27
pushed a commit
to LDrago27/opensearch-dashboards-functional-test
that referenced
this pull request
May 3, 2024
* initial skeleton Signed-off-by: Sam <samuel.costa@eliatra.com> * first two sections Signed-off-by: Sam <samuel.costa@eliatra.com> * first two sections Signed-off-by: Sam <samuel.costa@eliatra.com> * index pattern creation Signed-off-by: Sam <samuel.costa@eliatra.com> * index pattern creation Signed-off-by: Sam <samuel.costa@eliatra.com> * Bug Fixes Signed-off-by: Sam <samuel.costa@eliatra.com> * Cleanup Signed-off-by: Sam <samuel.costa@eliatra.com> * Cleanup Signed-off-by: Sam <samuel.costa@eliatra.com> * Cleanup Signed-off-by: Sam <samuel.costa@eliatra.com> * Refactor Signed-off-by: Sam <samuel.costa@eliatra.com> * Comment/ Extra line removal Signed-off-by: Sam <samuel.costa@eliatra.com> * Using loadSampleData command instead of custom method. Check if pattern was acually created Signed-off-by: Sam <samuel.costa@eliatra.com> --------- Signed-off-by: Sam <samuel.costa@eliatra.com>
SuZhou-Joe
pushed a commit
that referenced
this pull request
May 14, 2024
* initial skeleton Signed-off-by: Sam <samuel.costa@eliatra.com> * first two sections Signed-off-by: Sam <samuel.costa@eliatra.com> * first two sections Signed-off-by: Sam <samuel.costa@eliatra.com> * index pattern creation Signed-off-by: Sam <samuel.costa@eliatra.com> * index pattern creation Signed-off-by: Sam <samuel.costa@eliatra.com> * Bug Fixes Signed-off-by: Sam <samuel.costa@eliatra.com> * Cleanup Signed-off-by: Sam <samuel.costa@eliatra.com> * Cleanup Signed-off-by: Sam <samuel.costa@eliatra.com> * Cleanup Signed-off-by: Sam <samuel.costa@eliatra.com> * Refactor Signed-off-by: Sam <samuel.costa@eliatra.com> * Comment/ Extra line removal Signed-off-by: Sam <samuel.costa@eliatra.com> * Using loadSampleData command instead of custom method. Check if pattern was acually created Signed-off-by: Sam <samuel.costa@eliatra.com> --------- Signed-off-by: Sam <samuel.costa@eliatra.com> (cherry picked from commit e1e0716)
SuZhou-Joe
pushed a commit
that referenced
this pull request
Sep 3, 2024
* initial skeleton Signed-off-by: Sam <samuel.costa@eliatra.com> * first two sections Signed-off-by: Sam <samuel.costa@eliatra.com> * first two sections Signed-off-by: Sam <samuel.costa@eliatra.com> * index pattern creation Signed-off-by: Sam <samuel.costa@eliatra.com> * index pattern creation Signed-off-by: Sam <samuel.costa@eliatra.com> * Bug Fixes Signed-off-by: Sam <samuel.costa@eliatra.com> * Cleanup Signed-off-by: Sam <samuel.costa@eliatra.com> * Cleanup Signed-off-by: Sam <samuel.costa@eliatra.com> * Cleanup Signed-off-by: Sam <samuel.costa@eliatra.com> * Refactor Signed-off-by: Sam <samuel.costa@eliatra.com> * Comment/ Extra line removal Signed-off-by: Sam <samuel.costa@eliatra.com> * Using loadSampleData command instead of custom method. Check if pattern was acually created Signed-off-by: Sam <samuel.costa@eliatra.com> --------- Signed-off-by: Sam <samuel.costa@eliatra.com> (cherry picked from commit e1e0716)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Enhanced Sanity Tests
Issues Resolved
#3530
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.