Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Test] Reenable disable test case PointInTimeOperationTest.listAllPits_positive #3424

Closed
2 tasks
peternied opened this issue Sep 29, 2023 · 3 comments
Closed
2 tasks

[Test] Reenable disable test case PointInTimeOperationTest.listAllPits_positive #3424

peternied opened this issue Sep 29, 2023 · 3 comments
Labels
flaky-test Flaky Test issue good first issue These are recommended starting points for newcomers looking to make their first contributions. triaged Issues labeled as 'Triaged' have been reviewed and are deemed actionable.

Comments

@peternied
Copy link
Member

peternied commented Sep 29, 2023 •
edited
Loading

Description

Looks like the call to the cluster cleanUpPits is returning before all of the PITs have actually been deleted on the cluster.

Repo

  1. Go to src/integrationTest/java/org/opensearch/security/PointInTimeOperationTest.java
  2. Find the @Ignore entry on the test named listAllPits_positive
  3. Delete that attribute
  4. Run the tests with ./gradlew integrationTest --tests org.opensearch.security.PointInTimeOperationTest.listAllPits_positive

Exit Criteria

  • Ensure that PITs have been cleaned up in a deterministic way - note this could be a product change too
  • Run the test at least 10 times and see no failures - how to do this
@peternied peternied added the flaky-test Flaky Test issue label Sep 29, 2023
@github-actions github-actions bot added the untriaged Require the attention of the repository maintainers and may need to be prioritized label Sep 29, 2023
@peternied peternied changed the title Reenable disable test case PointInTimeOperationTest.listAllPits_positive [Test] Reenable disable test case PointInTimeOperationTest.listAllPits_positive Sep 29, 2023
@davidlago davidlago added good first issue These are recommended starting points for newcomers looking to make their first contributions. triaged Issues labeled as 'Triaged' have been reviewed and are deemed actionable. and removed untriaged Require the attention of the repository maintainers and may need to be prioritized labels Oct 2, 2023
@EduardoCorazon
Copy link
Contributor

Good evening @peternied , I would like to help contribute to this issue is that's ok.

@peternied
Copy link
Member Author

Sure, I've assigned this issue to you, thanks!

@EduardoCorazon EduardoCorazon mentioned this issue Oct 28, 2023
Closed
5 tasks
@cwperks cwperks mentioned this issue Dec 19, 2023
Merged
3 tasks
@peternied peternied mentioned this issue Jan 2, 2024
Merged
8 tasks
willyborankin pushed a commit that referenced this issue Jan 4, 2024
@cwperks
Re-enable disabled PIT integration tests (#3871)
f216743 
### Description

Re-enables 2 PIT integration tests that were previously disabled. This
adds a @before method to clean up all PITs created from previous test
cases to ensure each test case runs pristinely.

* Category (Enhancement, New feature, Bug fix, Test fix, Refactoring,
Maintenance, Documentation)

Test fix

### Issues Resolved

- #3424

Is this a backport? If so, please add backport PR # and/or commits #

### Testing
[Please provide details of testing done: unit testing, integration
testing and manual testing]

### Check List
- [ ] New functionality includes testing
- [ ] New functionality has been documented
- [ ] Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made
under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and
signing off your commits, please check
[here](https://github.com/opensearch-project/OpenSearch/blob/main/CONTRIBUTING.md#developer-certificate-of-origin).

---------

Signed-off-by: Craig Perkins <cwperx@amazon.com>
opensearch-trigger-bot bot pushed a commit that referenced this issue Jan 4, 2024
@github-actions
Re-enable disabled PIT integration tests (#3871)
7991da0 
### Description

Re-enables 2 PIT integration tests that were previously disabled. This
adds a @before method to clean up all PITs created from previous test
cases to ensure each test case runs pristinely.

* Category (Enhancement, New feature, Bug fix, Test fix, Refactoring,
Maintenance, Documentation)

Test fix

### Issues Resolved

- #3424

Is this a backport? If so, please add backport PR # and/or commits #

### Testing
[Please provide details of testing done: unit testing, integration
testing and manual testing]

### Check List
- [ ] New functionality includes testing
- [ ] New functionality has been documented
- [ ] Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made
under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and
signing off your commits, please check
[here](https://github.com/opensearch-project/OpenSearch/blob/main/CONTRIBUTING.md#developer-certificate-of-origin).

---------

Signed-off-by: Craig Perkins <cwperx@amazon.com>
(cherry picked from commit f216743)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
@stephen-crawford stephen-crawford self-assigned this Jan 4, 2024
@cwperks
Copy link
Member

cwperks commented Jan 4, 2024

This issue is now resolved with the merge of #3871.

@cwperks cwperks closed this as completed Jan 4, 2024
@stephen-crawford stephen-crawford removed their assignment Jan 4, 2024
dlin2028 pushed a commit to dlin2028/security that referenced this issue May 1, 2024
@cwperks @dlin2028
Re-enable disabled PIT integration tests (opensearch-project#3871)
bcaf30d 
### Description

Re-enables 2 PIT integration tests that were previously disabled. This
adds a @before method to clean up all PITs created from previous test
cases to ensure each test case runs pristinely.

* Category (Enhancement, New feature, Bug fix, Test fix, Refactoring,
Maintenance, Documentation)

Test fix

### Issues Resolved

- opensearch-project#3424

Is this a backport? If so, please add backport PR # and/or commits #

### Testing
[Please provide details of testing done: unit testing, integration
testing and manual testing]

### Check List
- [ ] New functionality includes testing
- [ ] New functionality has been documented
- [ ] Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made
under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and
signing off your commits, please check
[here](https://github.com/opensearch-project/OpenSearch/blob/main/CONTRIBUTING.md#developer-certificate-of-origin).

---------

Signed-off-by: Craig Perkins <cwperx@amazon.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
flaky-test Flaky Test issue good first issue These are recommended starting points for newcomers looking to make their first contributions. triaged Issues labeled as 'Triaged' have been reviewed and are deemed actionable.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
5 participants
@peternied @davidlago @cwperks @stephen-crawford @EduardoCorazon