-
Notifications
You must be signed in to change notification settings - Fork 158
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix button label #2130
Fix button label #2130
Conversation
Signed-off-by: Derek Ho <dxho@amazon.com>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2130 +/- ##
=======================================
Coverage 71.40% 71.40%
=======================================
Files 97 97
Lines 2651 2651
Branches 404 411 +7
=======================================
Hits 1893 1893
Misses 642 642
Partials 116 116 ☔ View full report in Codecov by Sentry. |
Signed-off-by: Derek Ho <dxho@amazon.com>
Signed-off-by: Derek Ho <dxho@amazon.com>
Signed-off-by: Derek Ho <dxho@amazon.com>
Just wanna share one of the solutions we are thinking in observability dashboards: opensearch-project/dashboards-observability#2187. So basically we added a specific step for compilation. cc @Swiddis |
Signed-off-by: Derek Ho <dxho@amazon.com>
514877c
Signed-off-by: Derek Ho <dxho@amazon.com>
Thanks, stole the compile step idea from the above PR and now it's working again. Maybe we should cut an issue to OSD core repo to make sure somebody is aware of this increase. It seems to have happened within the last 2 weeks, before that things were consistently under 600, now it is above. |
* Fix button label Signed-off-by: Derek Ho <dxho@amazon.com> * Debug Signed-off-by: Derek Ho <dxho@amazon.com> * look for server running instead of bundles compiled Signed-off-by: Derek Ho <dxho@amazon.com> * increase timeout to 900 seconds Signed-off-by: Derek Ho <dxho@amazon.com> * Actually change timeout to 900 seconds Signed-off-by: Derek Ho <dxho@amazon.com> * Try compile step Signed-off-by: Derek Ho <dxho@amazon.com> * Bash Signed-off-by: Derek Ho <dxho@amazon.com> * Fix messaging + look for start now that compile is different step Signed-off-by: Derek Ho <dxho@amazon.com> --------- Signed-off-by: Derek Ho <dxho@amazon.com> (cherry picked from commit dc3e5a9) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
* Fix button label * Debug * look for server running instead of bundles compiled * increase timeout to 900 seconds * Actually change timeout to 900 seconds * Try compile step * Bash * Fix messaging + look for start now that compile is different step --------- (cherry picked from commit dc3e5a9) Signed-off-by: Derek Ho <dxho@amazon.com> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Description
Fixes the button label for config.yml documentation on the "Get Started" page
Category
Bug fix
Why these changes are required?
Fix: #2129
What is the old behavior before changes and new behavior after changes?
Used to say "Create config.yml", now it says "Config.yml documentation"
Issues Resolved
Fix: #2129
Testing
Existing tests pass
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.