Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds page headers for updated UX #2083

Merged
merged 27 commits into from
Aug 19, 2024
Merged

Adds page headers for updated UX #2083

merged 27 commits into from
Aug 19, 2024

Conversation

DarshitChanpura
Copy link
Member

Description

Updates page headers for all security related pages when new home setting is turned on.

Upstream work being done waiting to be merged into core: https://github.com/AMoo-Miki/OpenSearch-Dashboards/tree/header-collective

Category

Enhancement

Why these changes are required?

To support new UX/UI

What is the old behavior before changes and new behavior after changes?

Issues Resolved

  • TBD

Testing

  • TBD

Check List

  • New functionality includes testing
  • New functionality has been documented
  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

… and user list pages

Signed-off-by: Darshit Chanpura <dchanp@amazon.com>
Signed-off-by: Darshit Chanpura <dchanp@amazon.com>
Signed-off-by: Darshit Chanpura <dchanp@amazon.com>
Signed-off-by: Darshit Chanpura <dchanp@amazon.com>
Signed-off-by: Darshit Chanpura <dchanp@amazon.com>
Signed-off-by: Darshit Chanpura <dchanp@amazon.com>
DarshitChanpura and others added 9 commits August 7, 2024 14:30
Signed-off-by: Darshit Chanpura <dchanp@amazon.com>
Signed-off-by: Darshit Chanpura <dchanp@amazon.com>
Signed-off-by: Derek Ho <dxho@amazon.com>
Signed-off-by: Derek Ho <dxho@amazon.com>
Signed-off-by: Derek Ho <dxho@amazon.com>
Signed-off-by: Derek Ho <dxho@amazon.com>
Signed-off-by: Derek Ho <dxho@amazon.com>
Signed-off-by: Derek Ho <dxho@amazon.com>
Signed-off-by: Derek Ho <dxho@amazon.com>
Copy link

codecov bot commented Aug 8, 2024

Codecov Report

Attention: Patch coverage is 61.11111% with 28 lines in your changes missing coverage. Please review.

Project coverage is 71.43%. Comparing base (e3da9b4) to head (040bc3e).
Report is 1 commits behind head on main.

Files Patch % Lines
.../apps/configuration/panels/role-view/role-view.tsx 30.00% 6 Missing and 1 partial ⚠️
public/apps/configuration/app-router.tsx 20.00% 4 Missing ⚠️
...ic/apps/configuration/header/header-components.tsx 66.66% 2 Missing and 2 partials ⚠️
public/apps/configuration/utils/context-menu.tsx 0.00% 3 Missing ⚠️
...uration/panels/permission-list/permission-list.tsx 71.42% 0 Missing and 2 partials ⚠️
public/apps/configuration/panels/role-list.tsx 66.66% 0 Missing and 2 partials ⚠️
...ps/configuration/panels/tenant-list/manage_tab.tsx 50.00% 1 Missing and 1 partial ⚠️
public/apps/configuration/panels/user-list.tsx 66.66% 0 Missing and 2 partials ⚠️
.../apps/configuration/panels/auth-view/auth-view.tsx 50.00% 1 Missing ⚠️
...s/configuration/panels/tenant-list/tenant-list.tsx 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2083      +/-   ##
==========================================
+ Coverage   71.04%   71.43%   +0.39%     
==========================================
  Files          96       97       +1     
  Lines        2604     2647      +43     
  Branches      392      408      +16     
==========================================
+ Hits         1850     1891      +41     
+ Misses        649      641       -8     
- Partials      105      115      +10     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

derek-ho and others added 7 commits August 9, 2024 12:01
Signed-off-by: Derek Ho <dxho@amazon.com>
…of all pages

Signed-off-by: Derek Ho <dxho@amazon.com>
Signed-off-by: Derek Ho <dxho@amazon.com>
… tests pass

Signed-off-by: Derek Ho <dxho@amazon.com>
Signed-off-by: Darshit Chanpura <dchanp@amazon.com>
Signed-off-by: Darshit Chanpura <dchanp@amazon.com>
Signed-off-by: Derek Ho <dxho@amazon.com>
@derek-ho derek-ho marked this pull request as ready for review August 12, 2024 18:27
@derek-ho derek-ho changed the title [WIP] Adds page headers for updated UX Adds page headers for updated UX Aug 12, 2024
@cwperks
Copy link
Member

cwperks commented Aug 16, 2024

@DarshitChanpura @derek-ho Is this PR blocked by the upstream branch mentioned in the description?

@derek-ho
Copy link
Collaborator

@DarshitChanpura @derek-ho Is this PR blocked by the upstream branch mentioned in the description?

No, according to @AMoo-Miki that branch has been merged into both main and 2.x so we are good on that front.

cwperks
cwperks previously approved these changes Aug 16, 2024
Copy link
Contributor

@stephen-crawford stephen-crawford left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall looks good, a few minor comments.

Signed-off-by: Derek Ho <dxho@amazon.com>
@derek-ho derek-ho dismissed stale reviews from stephen-crawford and cwperks via 442f525 August 19, 2024 18:54
Signed-off-by: Derek Ho <dxho@amazon.com>
@derek-ho derek-ho merged commit dc79df3 into main Aug 19, 2024
33 of 34 checks passed
@derek-ho derek-ho deleted the feature/page-header branch August 19, 2024 19:47
@derek-ho derek-ho added the backport 2.x backport to 2.x branch label Aug 19, 2024
@opensearch-trigger-bot
Copy link
Contributor

The backport to 2.x failed:

The process '/usr/bin/git' failed with exit code 128

To backport manually, run these commands in your terminal:

# Navigate to the root of your repository
cd $(git rev-parse --show-toplevel)
# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add ../.worktrees/security-dashboards-plugin/backport-2.x 2.x
# Navigate to the new working tree
pushd ../.worktrees/security-dashboards-plugin/backport-2.x
# Create a new branch
git switch --create backport/backport-2083-to-2.x
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 dc79df329c8ae5a991641677eef822f3de76703e
# Push it to GitHub
git push --set-upstream origin backport/backport-2083-to-2.x
# Go back to the original working tree
popd
# Delete the working tree
git worktree remove ../.worktrees/security-dashboards-plugin/backport-2.x

Then, create a pull request where the base branch is 2.x and the compare/head branch is backport/backport-2083-to-2.x.

derek-ho added a commit to derek-ho/security-dashboards-plugin that referenced this pull request Aug 19, 2024
* Adds initial commit to add header components and modifies get started and user list pages

Signed-off-by: Darshit Chanpura <dchanp@amazon.com>

* Updates auth-view page

Signed-off-by: Darshit Chanpura <dchanp@amazon.com>

* Updates user edit and create pages

Signed-off-by: Darshit Chanpura <dchanp@amazon.com>

* Updates user permissions page

Signed-off-by: Darshit Chanpura <dchanp@amazon.com>

* Updates dashboards tenancy page

Signed-off-by: Darshit Chanpura <dchanp@amazon.com>

* Updates dashboards audit logs page

Signed-off-by: Darshit Chanpura <dchanp@amazon.com>

* Updates roles and related pages

Signed-off-by: Darshit Chanpura <dchanp@amazon.com>

* Updates variable name and fixes indentation

Signed-off-by: Darshit Chanpura <dchanp@amazon.com>

* Push logic into new component

Signed-off-by: Derek Ho <dxho@amazon.com>

* Lint

Signed-off-by: Derek Ho <dxho@amazon.com>

* Migrate audit logging and tenant tabs to new page header

Signed-off-by: Derek Ho <dxho@amazon.com>

* Migrate all tabs to new component

Signed-off-by: Derek Ho <dxho@amazon.com>

* Remove prop and fix some test failures

Signed-off-by: Derek Ho <dxho@amazon.com>

* fix most tests

Signed-off-by: Derek Ho <dxho@amazon.com>

* Fix existing tests

Signed-off-by: Derek Ho <dxho@amazon.com>

* Push breadcrumb population into child components

Signed-off-by: Derek Ho <dxho@amazon.com>

* Migrate breadcrumbs into the page header component for the top level of all pages

Signed-off-by: Derek Ho <dxho@amazon.com>

* Lint

Signed-off-by: Derek Ho <dxho@amazon.com>

* Update all instances of breadcrumbs to new component and all existing tests pass

Signed-off-by: Derek Ho <dxho@amazon.com>

* Fixes target _blank redirects

Signed-off-by: Darshit Chanpura <dchanp@amazon.com>

* Fixes unit tests

Signed-off-by: Darshit Chanpura <dchanp@amazon.com>

* Add tests for new component and breadcrumb function

Signed-off-by: Derek Ho <dxho@amazon.com>

* Address PR feedback

Signed-off-by: Derek Ho <dxho@amazon.com>

* Update tests and snapshots

Signed-off-by: Derek Ho <dxho@amazon.com>

---------

Signed-off-by: Darshit Chanpura <dchanp@amazon.com>
Signed-off-by: Derek Ho <dxho@amazon.com>
Co-authored-by: Derek Ho <dxho@amazon.com>
(cherry picked from commit dc79df3)
Signed-off-by: Derek Ho <dxho@amazon.com>
derek-ho added a commit that referenced this pull request Aug 19, 2024
* Adds initial commit to add header components and modifies get started and user list pages



* Updates auth-view page



* Updates user edit and create pages



* Updates user permissions page



* Updates dashboards tenancy page



* Updates dashboards audit logs page



* Updates roles and related pages



* Updates variable name and fixes indentation



* Push logic into new component



* Lint



* Migrate audit logging and tenant tabs to new page header



* Migrate all tabs to new component



* Remove prop and fix some test failures



* fix most tests



* Fix existing tests



* Push breadcrumb population into child components



* Migrate breadcrumbs into the page header component for the top level of all pages



* Lint



* Update all instances of breadcrumbs to new component and all existing tests pass



* Fixes target _blank redirects



* Fixes unit tests



* Add tests for new component and breadcrumb function



* Address PR feedback



* Update tests and snapshots



---------




(cherry picked from commit dc79df3)

Signed-off-by: Darshit Chanpura <dchanp@amazon.com>
Signed-off-by: Derek Ho <dxho@amazon.com>
Co-authored-by: Darshit Chanpura <dchanp@amazon.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport 2.x backport to 2.x branch backport-failed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants