-
Notifications
You must be signed in to change notification settings - Fork 158
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make login screen input feels consistent #1993
Make login screen input feels consistent #1993
Conversation
50c24d2
to
8062878
Compare
The shading of the icons changed with opensearch-project#1980 and this removes the shading to make the fields look consistent. Signed-off-by: Miki <miki@amazon.com>
8062878
to
579dbd1
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1993 +/- ##
=======================================
Coverage 70.61% 70.61%
=======================================
Files 97 97
Lines 2600 2600
Branches 387 380 -7
=======================================
Hits 1836 1836
Misses 668 668
Partials 96 96 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @AMoo-Miki, and @kgcreative , thanks for the enhancement. Just one nit to double check: do we need to change back to the exact style that is prior to #1980? Or any style but same design for both username
and password
should be fine? In generally the change itself LGTM.
Hi @RyanL1997 -- since the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks
Description
Ran this by @kgcreative.
Turns
Into
Category
Bug fix
Why these changes are required?
What is the old behavior before changes and new behavior after changes?
Prior to #1980, we had
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.