Make login screen input feels consistent

[AMoo-Miki]

Description

Ran this by @kgcreative.

Turns

Into

Category

Bug fix

Why these changes are required?

What is the old behavior before changes and new behavior after changes?

Prior to #1980, we had

Check List

• New functionality includes testing
• New functionality has been documented
• Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 70.61%. Comparing base (9abc57d) to head (579dbd1).

Additional details and impacted files

@@           Coverage Diff           @@
##             main    #1993   +/-   ##
=======================================
  Coverage   70.61%   70.61%           
=======================================
  Files          97       97           
  Lines        2600     2600           
  Branches      387      380    -7     
=======================================
  Hits         1836     1836           
  Misses        668      668           
  Partials       96       96           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[RyanL1997]

Hi @AMoo-Miki, and @kgcreative , thanks for the enhancement. Just one nit to double check: do we need to change back to the exact style that is prior to #1980? Or any style but same design for both username and password should be fine? In generally the change itself LGTM.

[kgcreative]

Hi @RyanL1997 -- since the password field uses the input icon field instead of pre-pend, and the icon style is also consistent with search type fields, the style as Miki has updated it is internally consistent. Append makes sense for show/hide, but we made an explicit call here to move away from using both append and prepend for the login and password fields.

[derek-ho]

Thanks