Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor cypress OIDC tests to use Run Cypress Tests action #1755

Merged

Conversation

cwperks
Copy link
Member

@cwperks cwperks commented Jan 24, 2024

Description

Refactors the OpenID cypress tests to use the new Run Cypress Tests action introduced in #1729.

Category

Refactoring

Check List

  • New functionality includes testing
  • New functionality has been documented
  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Signed-off-by: Craig Perkins <cwperx@amazon.com>
Signed-off-by: Craig Perkins <cwperx@amazon.com>
Copy link

codecov bot commented Jan 24, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (f854cb3) 67.09% compared to head (1eb8f8f) 67.09%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1755   +/-   ##
=======================================
  Coverage   67.09%   67.09%           
=======================================
  Files          94       94           
  Lines        2404     2404           
  Branches      318      318           
=======================================
  Hits         1613     1613           
  Misses        713      713           
  Partials       78       78           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@stephen-crawford stephen-crawford merged commit d7d3c97 into opensearch-project:main Jan 24, 2024
15 checks passed
@cwperks cwperks added the backport 2.x backport to 2.x branch label Jan 24, 2024
@opensearch-trigger-bot
Copy link
Contributor

The backport to 2.x failed:

The process '/usr/bin/git' failed with exit code 1

To backport manually, run these commands in your terminal:

# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add .worktrees/backport-2.x 2.x
# Navigate to the new working tree
cd .worktrees/backport-2.x
# Create a new branch
git switch --create backport/backport-1755-to-2.x
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 d7d3c97fff1ec50dbcea2a0742cb5480175e1278
# Push it to GitHub
git push --set-upstream origin backport/backport-1755-to-2.x
# Go back to the original working tree
cd ../..
# Delete the working tree
git worktree remove .worktrees/backport-2.x

Then, create a pull request where the base branch is 2.x and the compare/head branch is backport/backport-1755-to-2.x.

cwperks added a commit to cwperks/security-dashboards-plugin that referenced this pull request Jan 24, 2024
…ch-project#1755)

* Refactor cypress OIDC tests to use Run Cypress Tests action

Signed-off-by: Craig Perkins <cwperx@amazon.com>

* Add steps to download and run keycloak

Signed-off-by: Craig Perkins <cwperx@amazon.com>

---------

Signed-off-by: Craig Perkins <cwperx@amazon.com>
(cherry picked from commit d7d3c97)
peternied pushed a commit that referenced this pull request Jan 25, 2024
…1756)

Signed-off-by: Craig Perkins <cwperx@amazon.com>
(cherry picked from commit d7d3c97)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport 2.x backport to 2.x branch
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants