Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cookie compression and splitting for JWT #1651

Merged
merged 13 commits into from
Jan 4, 2024
Merged

Cookie compression and splitting for JWT #1651

Changes from 1 commit
Commits
Show all changes
13 commits
Select commit Hold shift + click to select a range
506f868
Cookie compression and splitting for JWT
jochen-kressin Nov 14, 2023
8a25208
Make sure we can handle the case where no JWT config is explicitly set
jochen-kressin Nov 15, 2023
f37ee25
Adjust existing JWT Jest tests
jochen-kressin Nov 15, 2023
da9e753
Integration tests test
jochen-kressin Nov 15, 2023
393710d
Jest tests for reading the authHeaderValue
jochen-kressin Nov 17, 2023
86a41d3
Added a Jest/Selenium integration test for JWTs with a large payload
jochen-kressin Dec 5, 2023
9ac9ca9
Increase the jwt payload for the integration test
jochen-kressin Dec 6, 2023
fd928ce
Adjusted new tests to the style of the existing tests
jochen-kressin Dec 11, 2023
0f39953
Lint and some changes required by Typescript after the linter added i…
jochen-kressin Dec 11, 2023
a81f796
Linting
jochen-kressin Dec 11, 2023
7c532e6
Clear split cookies on logout
jochen-kressin Dec 31, 2023
2fe8a7c
Linting
jochen-kressin Dec 31, 2023
9f51173
Merge branch 'main' into cookie-splitting-for-jwt
cwperks Jan 4, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Linting 
Signed-off-by: Jochen Kressin <jochen.kressin-gh@eliatra.com>
  • Loading branch information
@jochen-kressin
jochen-kressin committed Dec 11, 2023
commit a81f796538787c5b7dd15c4a5074fd9ca8e8259f
7 changes: 5 additions & 2 deletions server/index.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@ import { schema, TypeOf } from '@osd/config-schema';
import { PluginInitializerContext, PluginConfigDescriptor } from '../../../src/core/server';
import { SecurityPlugin } from './plugin';
import { AuthType } from '../common';
import { JWT_DEFAULT_EXTRA_STORAGE_OPTIONS } from "./auth/types/jwt/jwt_auth";
import { JWT_DEFAULT_EXTRA_STORAGE_OPTIONS } from './auth/types/jwt/jwt_auth';

const validateAuthType = (value: string[]) => {
const supportedAuthTypes = [
Expand Down Expand Up @@ -239,7 +239,10 @@ export const configSchema = schema.object({
defaultValue: JWT_DEFAULT_EXTRA_STORAGE_OPTIONS.cookiePrefix,
minLength: 2,
}),
additional_cookies: schema.number({ min: 1, defaultValue: JWT_DEFAULT_EXTRA_STORAGE_OPTIONS.additionalCookies }),
additional_cookies: schema.number({
min: 1,
defaultValue: JWT_DEFAULT_EXTRA_STORAGE_OPTIONS.additionalCookies,
}),
}),
})
),
Expand Down
Loading