Fix bug where custom permission groups are missing

[derek-ho]

Description

Fix custom/kibana/all permission groups missing from dropdown. This was because I had assumed there were only "cluster" and "index" type groups, whereas there are also custom, kibana, and all types for permission groups. This has slight duplication since the custom types will show up in both cluster and index dropdowns, but this fixes the bug.

More details here: #1636 (comment)

Category

[Enhancement, New feature, Bug fix, Test fix, Refactoring, Maintenance, Documentation]

Why these changes are required?

What is the old behavior before changes and new behavior after changes?

Issues Resolved

FIX: #1597

Testing

[Please provide details of testing done: unit testing, integration testing and manual testing]

Check List

• New functionality includes testing
• New functionality has been documented
• Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

[derek-ho]

Brief description/background of the change. The following are the types of groups:

security-dashboards-plugin/public/apps/configuration/types.ts

Line 149 in c784665

type: 'cluster' | 'index' | 'all' | 'kibana' | undefined;

. cluster and index are self explanatory and are already being filtered in the section, which I have renamed to be more specific about the groups. There is also kibana, which corresponds to dashboards action groups, which are handled in the Tenant Panel (i.e. not relevant to this PR). There is also all, which corresponds to unlimited, which describes the following group:

{
    "reserved": true,
    "hidden": false,
    "allowed_actions": [
        "*"
    ],
    "type": "all",
    "description": "Allow all",
    "static": true
}

Not sure how this would be used, hence only restricting other permission groups to undefined, which corresponds to custom permission groups, addressing the initial issue.

[codecov]

Codecov Report

Merging #1636 (95a083e) into main (c784665) will decrease coverage by 1.70%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main    #1636      +/-   ##
==========================================
- Coverage   67.99%   66.29%   -1.70%     
==========================================
  Files          93       93              
  Lines        2340     2344       +4     
  Branches      317      317              
==========================================
- Hits         1591     1554      -37     
  Misses        720      720              
- Partials       29       70      +41     

Files	Coverage Δ
.../apps/configuration/panels/role-edit/role-edit.tsx	84.37% <100.00%> (+1.04%)	⬆️

... and 17 files with indirect coverage changes

[cwperks]

This PR looks good to me, but IMO this experience is a bit confusing and should be better addressed in a future PR. There are 2 dropdowns in the frontend where permissions groups can be assigned. They are in the cluster permissions dropdown and the index permissions dropdown. From this, it is not abundantly clear which of those dropdowns a custom permission group would be applicable to.