Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update permissions according to backend #1480

Merged
merged 1 commit into from
Jun 22, 2023
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
38 changes: 19 additions & 19 deletions public/apps/configuration/constants.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -213,6 +213,25 @@ export const CLUSTER_PERMISSIONS: string[] = [
'restapi:admin/ssl/certs/info',
'restapi:admin/ssl/certs/reload',
'restapi:admin/tenants',
'indices:admin/template/delete',
'indices:admin/template/get',
'indices:admin/template/put',
'indices:admin/index_template/delete',
'indices:admin/index_template/get',
'indices:admin/index_template/put',
'indices:admin/index_template/simulate',
'indices:admin/index_template/simulate_index',
'indices:data/read/scroll',
'indices:data/read/scroll/clear',
'indices:data/write/bulk',
'indices:data/write/bulk*',
'indices:data/read/mget',
'indices:data/read/mget*',
'indices:data/read/msearch',
'indices:data/read/msearch/template',
'indices:data/read/mtv',
'indices:data/read/mtv*',
'indices:data/write/reindex',
];

export function includeClusterPermissions(clusterPermissionsToInclude: string[]) {
Expand Down Expand Up @@ -241,11 +260,6 @@ export const INDEX_PERMISSIONS: string[] = [
'indices:admin/flush*',
'indices:admin/forcemerge',
'indices:admin/get',
'indices:admin/index_template/delete',
'indices:admin/index_template/get',
'indices:admin/index_template/put',
'indices:admin/index_template/simulate',
'indices:admin/index_template/simulate_index',
'indices:admin/mapping/auto_put',
'indices:admin/mapping/put',
'indices:admin/mappings/fields/get',
Expand All @@ -265,37 +279,23 @@ export const INDEX_PERMISSIONS: string[] = [
'indices:admin/shards/search_shards',
'indices:admin/shrink',
'indices:admin/synced_flush',
'indices:admin/template/delete',
'indices:admin/template/get',
'indices:admin/template/put',
'indices:admin/types/exists',
'indices:admin/upgrade',
'indices:admin/validate/query',
'indices:data/read/explain',
'indices:data/read/field_caps',
'indices:data/read/field_caps*',
'indices:data/read/get',
'indices:data/read/mget',
'indices:data/read/mget*',
Comment on lines -278 to -279
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

backend says equal to indices:data/read/mget should it include the * as well?

'indices:data/read/msearch',
'indices:data/read/msearch/template',
Comment on lines -280 to -281
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

backend says equal to indices:data/read/msearch - should it include the /template as well

'indices:data/read/mtv',
'indices:data/read/mtv*',
Comment on lines -282 to -283
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

backend says equal to indices:data/read/mtv should it include the * as well

'indices:data/read/point_in_time/create',
'indices:data/read/point_in_time/delete',
'indices:data/read/point_in_time/readall',
'indices:data/read/scroll',
'indices:data/read/scroll/clear',
'indices:data/read/search',
'indices:data/read/search*',
'indices:data/read/search/template',
'indices:data/read/tv',
'indices:data/write/bulk',
'indices:data/write/bulk*',
Comment on lines -293 to -294
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

backend says equal to indices:data/write/bulk - should it include the * as well?

'indices:data/write/delete',
'indices:data/write/delete/byquery',
'indices:data/write/index',
'indices:data/write/reindex',
'indices:data/write/update',
'indices:data/write/update/byquery',
'indices:monitor/data_stream/stats',
Expand Down