Move security plugin from Plugin to Management section on left navigation menu #1474
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Hailong-am
commented
Jun 19, 2023
Codecov Report
@@ Coverage Diff @@
## main #1474 +/- ##
==========================================
- Coverage 65.62% 65.61% -0.02%
==========================================
Files 93 93
Lines 2307 2309 +2
Branches 314 315 +1
==========================================
+ Hits 1514 1515 +1
- Misses 725 726 +1
Partials 68 68
|
Signed-off-by: Hailong Cui <ihailong@amazon.com>
Signed-off-by: Hailong Cui <ihailong@amazon.com>
Signed-off-by: Hailong Cui <ihailong@amazon.com>
Hailong-am
force-pushed
the
feature/navigation_changes_2
branch
from
67c9039
to
9ff95c5
Compare
Hailong-am
requested review from
cliu123,
cwperks,
DarshitChanpura,
davidlago,
peternied,
RyanL1997 and
stephen-crawford
as code owners
cwperks
reviewed
Jun 20, 2023
There was a problem hiding this comment.
@Hailong-am This change looks good to me. I will re-run the failing checks as soon as new artifacts become available so that they do not get stuck on this error:
java.lang.NoClassDefFoundError: org/opensearch/core/common/io/stream/BaseStreamInput
|
@Hailong-am Should this PR be backported to 2.x? Is this targeted for 2.9? |
cwperks
approved these changes
Jun 23, 2023
@cwperks thanks for reviewing the code. It's target for 2.9, please help to add backport 2.x label. |
|
Added the backport 2.x label. @RyanL1997 @cliu123 Could this PR get another review? |
davidlago
approved these changes
Jun 29, 2023
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Jun 29, 2023
…tion menu (#1474) * move security management section Signed-off-by: Hailong Cui <ihailong@amazon.com> * Fix eslint Signed-off-by: Hailong Cui <ihailong@amazon.com> * Remove plugins pages for management overview registration Signed-off-by: Hailong Cui <ihailong@amazon.com> --------- Signed-off-by: Hailong Cui <ihailong@amazon.com> Co-authored-by: Darshit Chanpura <35282393+DarshitChanpura@users.noreply.github.com> Co-authored-by: Craig Perkins <cwperx@amazon.com> (cherry picked from commit c74973a)
davidlago
pushed a commit
that referenced
this pull request
Jun 29, 2023
…tion menu (#1474) (#1495) * move security management section Signed-off-by: Hailong Cui <ihailong@amazon.com> * Fix eslint Signed-off-by: Hailong Cui <ihailong@amazon.com> * Remove plugins pages for management overview registration Signed-off-by: Hailong Cui <ihailong@amazon.com> --------- Signed-off-by: Hailong Cui <ihailong@amazon.com> Co-authored-by: Darshit Chanpura <35282393+DarshitChanpura@users.noreply.github.com> Co-authored-by: Craig Perkins <cwperx@amazon.com> (cherry picked from commit c74973a) Co-authored-by: Hailong Cui <ihailong@amazon.com>
samuelcostae
pushed a commit
to samuelcostae/security-dashboards-plugin
that referenced
this pull request
Aug 10, 2023
…tion menu (opensearch-project#1474) * move security management section Signed-off-by: Hailong Cui <ihailong@amazon.com> * Fix eslint Signed-off-by: Hailong Cui <ihailong@amazon.com> * Remove plugins pages for management overview registration Signed-off-by: Hailong Cui <ihailong@amazon.com> --------- Signed-off-by: Hailong Cui <ihailong@amazon.com> Co-authored-by: Darshit Chanpura <35282393+DarshitChanpura@users.noreply.github.com> Co-authored-by: Craig Perkins <cwperx@amazon.com> Signed-off-by: Sam <samuel.costa@eliatra.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Move security plugin from Plugin to Management section on left navigation menu
Category
Enhancement
Why these changes are required?
It is part of Navigation changes for administrative features
What is the old behavior before changes and new behavior after changes?
Before
After
Issues Resolved
#1435
Testing
[Please provide details of testing done: unit testing, integration testing and manual testing]
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.