-
Notifications
You must be signed in to change notification settings - Fork 158
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Move security plugin from Plugin to Management section on left navigation menu #1474
Move security plugin from Plugin to Management section on left navigation menu #1474
Conversation
Codecov Report
@@ Coverage Diff @@
## main #1474 +/- ##
==========================================
- Coverage 65.62% 65.61% -0.02%
==========================================
Files 93 93
Lines 2307 2309 +2
Branches 314 315 +1
==========================================
+ Hits 1514 1515 +1
- Misses 725 726 +1
Partials 68 68
|
Signed-off-by: Hailong Cui <ihailong@amazon.com>
Signed-off-by: Hailong Cui <ihailong@amazon.com>
Signed-off-by: Hailong Cui <ihailong@amazon.com>
67c9039
to
9ff95c5
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Hailong-am This change looks good to me. I will re-run the failing checks as soon as new artifacts become available so that they do not get stuck on this error:
java.lang.NoClassDefFoundError: org/opensearch/core/common/io/stream/BaseStreamInput
@Hailong-am Should this PR be backported to 2.x? Is this targeted for 2.9? |
@cwperks thanks for reviewing the code. It's target for 2.9, please help to add backport 2.x label. |
Added the backport 2.x label. @RyanL1997 @cliu123 Could this PR get another review? |
…tion menu (#1474) * move security management section Signed-off-by: Hailong Cui <ihailong@amazon.com> * Fix eslint Signed-off-by: Hailong Cui <ihailong@amazon.com> * Remove plugins pages for management overview registration Signed-off-by: Hailong Cui <ihailong@amazon.com> --------- Signed-off-by: Hailong Cui <ihailong@amazon.com> Co-authored-by: Darshit Chanpura <35282393+DarshitChanpura@users.noreply.github.com> Co-authored-by: Craig Perkins <cwperx@amazon.com> (cherry picked from commit c74973a)
…tion menu (#1474) (#1495) * move security management section Signed-off-by: Hailong Cui <ihailong@amazon.com> * Fix eslint Signed-off-by: Hailong Cui <ihailong@amazon.com> * Remove plugins pages for management overview registration Signed-off-by: Hailong Cui <ihailong@amazon.com> --------- Signed-off-by: Hailong Cui <ihailong@amazon.com> Co-authored-by: Darshit Chanpura <35282393+DarshitChanpura@users.noreply.github.com> Co-authored-by: Craig Perkins <cwperx@amazon.com> (cherry picked from commit c74973a) Co-authored-by: Hailong Cui <ihailong@amazon.com>
…tion menu (opensearch-project#1474) * move security management section Signed-off-by: Hailong Cui <ihailong@amazon.com> * Fix eslint Signed-off-by: Hailong Cui <ihailong@amazon.com> * Remove plugins pages for management overview registration Signed-off-by: Hailong Cui <ihailong@amazon.com> --------- Signed-off-by: Hailong Cui <ihailong@amazon.com> Co-authored-by: Darshit Chanpura <35282393+DarshitChanpura@users.noreply.github.com> Co-authored-by: Craig Perkins <cwperx@amazon.com> Signed-off-by: Sam <samuel.costa@eliatra.com>
Description
Move security plugin from Plugin to Management section on left navigation menu
Category
Enhancement
Why these changes are required?
It is part of Navigation changes for administrative features
What is the old behavior before changes and new behavior after changes?
Before
After
Issues Resolved
#1435
Testing
[Please provide details of testing done: unit testing, integration testing and manual testing]
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.