-
Notifications
You must be signed in to change notification settings - Fork 158
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
SAML Integration Tests #1088
Merged
cwperks
merged 46 commits into
opensearch-project:main
from
devardee:saml_integ_tests_raise_pr
Sep 19, 2022
Merged
SAML Integration Tests #1088
Changes from 1 commit
Commits
Show all changes
46 commits
Select commit
Hold shift + click to select a range
861c909
Refactor + add support to run saml based integ tests via selenium web…
devardee c42dacc
Add plugins.security.unsupported.restapi.allow_securityconfig_modific…
devardee 7415746
Add one more test
devardee a1afaa5
Added tests for checking tenancy retention after logout in SAML
expani 381de0c
Lint formatting fixes
expani 69c765f
Removed unused imports
expani 2234f77
Add plugins.security.unsupported.restapi.allow_securityconfig_modific…
devardee 776e134
Added License header
expani 4e73818
Added building the plugin bundles while running ITs
expani d68808a
Merge remote-tracking branch 'upstream/main' into saml_integ_tests_ra…
expani 1a641ba
Signed off the commit
expani 016087c
Added debug loggers for checking IT failures
expani 4c3561a
Added debug loggers for checking IT failures
expani 5c486b4
Added debug loggers for checking IT failures
expani fc133ae
Added debug loggers for checking IT failures
expani a39fa6f
Added a new stage for debug loggers before cleanup
expani 15f7483
Added a new stage for debug loggers before cleanup
expani 07688fa
Added logger to print error recieved from auth info during saml login
expani a0338d4
Added Docker host N/W Config to allow connection to SAML IDP
expani ad54b42
Added discovery type config to be single node for passing bootstrap c…
expani abff13a
Debug loggers
expani 60f97f4
Debug loggers
expani 85492d9
Debug loggers
expani 6423819
Reverted run command to see change in error
expani 11dbee5
Trying with full docker image of OS
expani 8062541
Refactored the integration test yaml to use OS Full Docker image
expani dc52652
Removed all debug loggers
expani e07ffb9
Added selfSigned package for generating certs and integrated with sam…
expani 9fa7fbf
Deleted checked-in key and cert for saml-idp server
expani edf19e3
Reverted use of docker image and testing again with manual build
expani 73d5251
Reverted use of docker image and testing again with manual build
expani ce0708b
Merge remote-tracking branch 'upstream/main' into saml_integ_tests_ra…
expani ae2f818
Upgraded version from 2.3 to 2.4
expani 9b45c10
Removed debug pointers
expani 22a1ac2
Commented out failing IT temporarily
expani cd10d35
Rebased with upstream main and removed comment for Lint tests to pass
expani 89950cc
Lint formatting fix
expani 4c696e4
Added the commented failing test back again
expani 8253163
Merge remote-tracking branch 'upstream/main' into saml_integ_tests_ra…
expani 51ad38a
Removed assertion from test again to make it pass
expani 847bc2d
Used a better XPath and improved error logging in tests
expani c10cf2c
Removed an unused XPath
expani 9af274a
Added back the assertion for failing IT
expani f6d8032
Added steps to run Selenium based Integ Tests
expani f247dbb
Commented out the test, will re-enable it again in the fix PR
expani fba014d
Parameterized the getDriver function
expani File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Added selfSigned package for generating certs and integrated with sam…
…l-idp Signed-off-by: Aniketh Jain <anijainc@amazon.com>
- Loading branch information
commit e07ffb9d155906a15347d36f1e1e01a27fe2f028
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@peterzhuamazon @bbarani Are there any concerns on building selenium into release?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@anijain-Amazon Would it be possible to add these tests in opensearch-dashboards-functional-test and implement with Cypress? There has already been a well-automated workflow in place where developers can easily implement tests and the tests run with each build. With the workflow, developers do not have to worry about setting up clusters and configurations. They can just focus on implementing tests and the workflow takes care of everything else. In comparison, Selenium would be a brand new test framework that would require some changes in Infra for release build.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@cliu123 currently cypress does not support saml auth workflow cypress-io/cypress#5397, so we went with selenium
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I see. Thanks for the information!
@kavilla @peterzhuamazon Please be aware of this new test dependency Selenium.