make threat intel async #703
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Subhobrata Dey <sbcd90@gmail.com>
sbcd90
requested review from
amsiglan,
AWSHurneyt,
getsaurabh02,
lezzago,
praveensameneni and
eirsep
as code owners
Codecov Report
@@ Coverage Diff @@
## main #703 +/- ##
============================================
- Coverage 26.99% 25.18% -1.82%
+ Complexity 1068 1021 -47
============================================
Files 274 275 +1
Lines 12352 12458 +106
Branches 1343 1361 +18
============================================
- Hits 3334 3137 -197
- Misses 8745 9053 +308
+ Partials 273 268 -5
|
praveensameneni
approved these changes
Oct 31, 2023
eirsep
approved these changes
Oct 31, 2023
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Oct 31, 2023
Signed-off-by: Subhobrata Dey <sbcd90@gmail.com> (cherry picked from commit 0dd9787)
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Oct 31, 2023
Signed-off-by: Subhobrata Dey <sbcd90@gmail.com> (cherry picked from commit 0dd9787)
eirsep
pushed a commit
that referenced
this pull request
Oct 31, 2023
| createThreatIntelFeedData(); | ||
| tifdIndex = getLatestIndexByCreationDate(); | ||
| createThreatIntelFeedData(listener); | ||
| } else { |
There was a problem hiding this comment.
Why this should be in else? Dont we need to do even when tifIndex was null and after it is populated in if?
There was a problem hiding this comment.
similar search request has been made in the createThreatIntelFeedData() method once the index creation is done.
sbcd90
pushed a commit
that referenced
this pull request
Oct 31, 2023
jowg-amazon
added a commit
to jowg-amazon/security-analytics
that referenced
this pull request
Nov 8, 2023
…project#704)" This reverts commit 5b4ab6c.
jowg-amazon
added a commit
to jowg-amazon/security-analytics
that referenced
this pull request
Nov 8, 2023
…project#704)" This reverts commit 5b4ab6c. Signed-off-by: Joanne Wang <jowg@amazon.com>
jowg-amazon
added a commit
to jowg-amazon/security-analytics
that referenced
this pull request
Nov 8, 2023
…project#704)" This reverts commit 5b4ab6c. Signed-off-by: Joanne Wang <jowg@amazon.com>
AWSHurneyt
pushed a commit
that referenced
this pull request
Nov 8, 2023
* Revert "make threat intel async (#703) (#704)" This reverts commit 5b4ab6c. Signed-off-by: Joanne Wang <jowg@amazon.com> * Revert "Integrate threat intel feeds (#669) (#690)" This reverts commit 559d97e. Signed-off-by: Joanne Wang <jowg@amazon.com> --------- Signed-off-by: Joanne Wang <jowg@amazon.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
this pr changes the logic of threat intel implementation to use listeners and removes blocking Future.actionGet() calls from the code which fails test validations.
Issues Resolved
[List any issues this PR will resolve]
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.