Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Bug] Fixed ListIOCs number of findings cap. #1373

Draft
wants to merge 2 commits into
base: main
Choose a base branch
from
Draft

[Bug] Fixed ListIOCs number of findings cap. #1373

wants to merge 2 commits into from

Conversation

AWSHurneyt
Copy link
Collaborator

Description

  1. Fixed total IOCs count capping at 10,000.
  2. Fixed number of findings per IOC capping at 10,000.

Related Issues

Resolves #1191

Check List

  • New functionality includes testing.
  • New functionality has been documented.
  • API changes companion pull request created.
  • Commits are signed per the DCO using --signoff.
  • Public documentation issue/PR created.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@AWSHurneyt
Fixed finding number returned by ListIOCs API capping at 10,000.
81c5ffd 
Signed-off-by: AWSHurneyt <hurneyt@amazon.com>
@AWSHurneyt
Added integ test for fix.
ea2f525 
Signed-off-by: AWSHurneyt <hurneyt@amazon.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@amsiglan amsiglan Awaiting requested review from amsiglan amsiglan will be requested when the pull request is marked ready for review amsiglan is a code owner

@getsaurabh02 getsaurabh02 Awaiting requested review from getsaurabh02 getsaurabh02 will be requested when the pull request is marked ready for review getsaurabh02 is a code owner

@lezzago lezzago Awaiting requested review from lezzago lezzago will be requested when the pull request is marked ready for review lezzago is a code owner

@praveensameneni praveensameneni Awaiting requested review from praveensameneni praveensameneni will be requested when the pull request is marked ready for review praveensameneni is a code owner

@sbcd90 sbcd90 Awaiting requested review from sbcd90 sbcd90 will be requested when the pull request is marked ready for review sbcd90 is a code owner

@eirsep eirsep Awaiting requested review from eirsep eirsep will be requested when the pull request is marked ready for review eirsep is a code owner

@jowg-amazon jowg-amazon Awaiting requested review from jowg-amazon jowg-amazon will be requested when the pull request is marked ready for review jowg-amazon is a code owner

@engechas engechas Awaiting requested review from engechas engechas will be requested when the pull request is marked ready for review engechas is a code owner

@goyamegh goyamegh Awaiting requested review from goyamegh goyamegh will be requested when the pull request is marked ready for review goyamegh is a code owner

@riysaxen-amzn riysaxen-amzn Awaiting requested review from riysaxen-amzn riysaxen-amzn will be requested when the pull request is marked ready for review riysaxen-amzn is a code owner

At least 2 approving reviews are required to merge this pull request.

Assignees
No one assigned
Labels
backport 2.x backport 2.15 backport 2.16 backport 2.17
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[BUG] ListIOCsAPI total hits, and findings count per IOC are incorrect
1 participant
@AWSHurneyt