Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated the cypress workflow to support overriding the dependency versions. #629

Merged

Conversation

AWSHurneyt
Copy link
Collaborator

@AWSHurneyt AWSHurneyt commented Jun 13, 2023

Description

Updated the cypress workflow to support overriding the dependency versions.

This difference between this PR and PR #618 is this PR does not adjust the version of this package from 3.0.0. This preserves the project branching strategy.

Issues Resolved

[List any issues this PR will resolve]

Check List

  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

…sions.

Signed-off-by: AWSHurneyt <hurneyt@amazon.com>
@codecov
Copy link

codecov bot commented Jun 13, 2023

Codecov Report

Merging #629 (3a65403) into main (db0354e) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main     #629   +/-   ##
=======================================
  Coverage   31.48%   31.48%           
=======================================
  Files         138      138           
  Lines        4335     4335           
  Branches      771      721   -50     
=======================================
  Hits         1365     1365           
  Misses       2832     2832           
  Partials      138      138           

Signed-off-by: AWSHurneyt <hurneyt@amazon.com>
Signed-off-by: AWSHurneyt <hurneyt@amazon.com>
Signed-off-by: AWSHurneyt <hurneyt@amazon.com>
Signed-off-by: AWSHurneyt <hurneyt@amazon.com>
…ocess.

Signed-off-by: AWSHurneyt <hurneyt@amazon.com>
Signed-off-by: AWSHurneyt <hurneyt@amazon.com>
Signed-off-by: AWSHurneyt <hurneyt@amazon.com>
Signed-off-by: AWSHurneyt <hurneyt@amazon.com>
Signed-off-by: AWSHurneyt <hurneyt@amazon.com>
@AWSHurneyt
Copy link
Collaborator Author

Let's not backport this PR for now; it should really only be needed on the main branch, as that's ideally the only branch that should ever be unstable.

We can see in test output before overriding the versions that Override Package Versions job was skipped because the associated variables were blank, and that the cypress workflow failed.
Worklow configuration before override
Test failures
And that the cypress workflow is now succeeding with the version overrides without having to adjust the package version.

@AWSHurneyt AWSHurneyt marked this pull request as ready for review June 14, 2023 00:48
@AWSHurneyt AWSHurneyt merged commit d2e78c5 into opensearch-project:main Jun 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants