Bump version and add notebooks context menu fix for 1.0.1.0 patch #142
Conversation
Signed-off-by: David Cui <davidcui@amazon.com>
Codecov Report
@@ Coverage Diff @@
## 1.0 #142 +/- ##
=========================================
Coverage 63.41% 63.41%
Complexity 309 309
=========================================
Files 101 101
Lines 4401 4401
Branches 669 669
=========================================
Hits 2791 2791
Misses 1442 1442
Partials 168 168
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
| @@ -55,7 +55,7 @@ export const isValidRelativeUrl = (relativeUrl: string) => { | |||
| export const regexDuration = /^(-?)P(?=\d|T\d)(?:(\d+)Y)?(?:(\d+)M)?(?:(\d+)([DW]))?(?:T(?:(\d+)H)?(?:(\d+)M)?(?:(\d+(?:\.\d+)?)S)?)?$/; | |||
| export const regexEmailAddress = /\S+@\S+\.\S+/; | |||
| export const regexReportName = /^[\w\-\s\(\)\[\]\,\_\-+]+$/; | |||
| export const regexRelativeUrl = /^\/(_plugin\/kibana\/app|app)\/(dashboards|visualize|discover|notebooks-dashboards\?view=output_only)(\?security_tenant=.+|)#\/(view\/|edit\/)?[^\/]+$/; | |||
| export const regexRelativeUrl = /^\/(_dashboards\/app|app)\/(dashboards|visualize|discover|notebooks-dashboards\?view=output_only)([?&]security_tenant=.+|)#\/(view\/|edit\/)?[^\/]+$/; | |||
There was a problem hiding this comment.
why is this (_dashboards\/app|app) instead of the (_plugin\/kibana\/|_dashboards\/)?app in main branch?
There was a problem hiding this comment.
I am going off the state of the file from the last PR we pushed to fix the notebooks context menu bug #118. For the PR #132 where the contents were changed to (_plugin\/kibana\/|_dashboards\/)?app, was that to patch for the same bug? If not, I don't think it should go into the patch release unless it's resolving another similar breaking issue?
There was a problem hiding this comment.
i see, could you link issue and commit you picked in the description? thanks
There was a problem hiding this comment.
it's better we should keep the commit history for patch, right? Can you not co-author on one commit, just keep the original one and add a new commit which only bumps version. Then we do a merge or rebase&merge on github?
There was a problem hiding this comment.
Currently we are co-authored on the first commit not including the version changes or workflow change, I just had to do some manual work there because the cherry-pick failed for some reason even after fetching
Signed-off-by: David Cui <davidcui@amazon.com>
Signed-off-by: David Cui <davidcui@amazon.com>
Signed-off-by: David Cui davidcui@amazon.com
Bumps version to
1.0.1.0and adds remaining notebooks patch fix that was not merged into1.0for GA releaseAdd changes from #118
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.