Skip to content

Skip profile queries #298

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Apr 15, 2025
Merged

Skip profile queries #298

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
279ca11
Skip profile queries
Apr 13, 2025
067838f
FEAT 180: Refactor UT for skip profile query
quangdutran Apr 15, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions src/main/java/org/opensearch/plugin/insights/core/listener/QueryInsightsListener.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -221,6 +221,11 @@ public void onRequestFailure(final SearchPhaseContext context, final SearchReque
}

private void constructSearchQueryRecord(final SearchPhaseContext context, final SearchRequestContext searchRequestContext) {
// Skip profile queries
if (searchRequestContext.getRequest().source().profile()) {
return;
}

SearchTask searchTask = context.getTask();
List<TaskResourceInfo> tasksResourceUsages = searchRequestContext.getPhaseResourceUsage();
tasksResourceUsages.add(
Expand Down
10 changes: 9 additions & 1 deletion src/test/java/org/opensearch/plugin/insights/core/listener/QueryInsightsListenerTests.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -79,7 +79,7 @@ public void setup() {
ClusterServiceUtils.setState(clusterService, state);
when(queryInsightsService.isCollectionEnabled(MetricType.LATENCY)).thenReturn(true);
when(queryInsightsService.getTopQueriesService(MetricType.LATENCY)).thenReturn(topQueriesService);

when(searchRequestContext.getRequest()).thenReturn(searchRequest);
ThreadContext threadContext = new ThreadContext(Settings.EMPTY);
threadPool.getThreadContext().setHeaders(new Tuple<>(Collections.singletonMap(Task.X_OPAQUE_ID, "userLabel"), new HashMap<>()));
}
Expand Down Expand Up @@ -345,4 +345,12 @@ private QueryInsightsListener testFeatureEnableDisableSetup(

return queryInsightsListener;
}

public void testSkipProfileQuery() {
SearchSourceBuilder searchSourceBuilder = new SearchSourceBuilder().profile(true);
when(searchRequest.source()).thenReturn(searchSourceBuilder);
QueryInsightsListener queryInsightsListener = new QueryInsightsListener(clusterService, queryInsightsService);
queryInsightsListener.onRequestEnd(searchPhaseContext, searchRequestContext);
verify(queryInsightsService, times(0)).addRecord(any());
}
}
Loading