Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add new blog post for website search functionality #3391

Open
wants to merge 5 commits into
base: main
Choose a base branch
from

Conversation

zelinh
Copy link
Member

@zelinh zelinh commented Oct 15, 2024

Description

Add new blog post for website search functionality

Issues Resolved

#3379

Check List

  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the BSD-3-Clause License.

Signed-off-by: Zelin Hao <zelinhao@amazon.com>
@pajuric
Copy link

pajuric commented Oct 18, 2024

@zelinh - Thanks for the contribution. I'll reach out to you on Slack.

@pajuric
Copy link

pajuric commented Oct 21, 2024

@zelinh - Please use sentence case for headlines/titles and section headers. For example, "Enhanced Search Infrastructure" should be "Enhanced search infrastructure."

@zelinh
Copy link
Member Author

zelinh commented Oct 21, 2024

@zelinh - Please use sentence case for headlines/titles and section headers. For example, "Enhanced Search Infrastructure" should be "Enhanced search infrastructure."

Updated in the new commit. Thanks.

Signed-off-by: Zelin Hao <zelinhao@amazon.com>
Signed-off-by: Fanit Kolchina <kolchfa@amazon.com>
Copy link
Collaborator

@natebower natebower left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@kolchfa-aws @zelinh Editorial review complete. Nicely written! Please see my comments and changes and let me know if you have any questions.

Cc: @pajuric

Co-authored-by: Nathan Bower <nbower@amazon.com>
Signed-off-by: kolchfa-aws <105444904+kolchfa-aws@users.noreply.github.com>
@kolchfa-aws
Copy link
Collaborator

Thank you, @natebower! I addressed your comments.

@natebower
Copy link
Collaborator

Thank you, @natebower! I addressed your comments.

Thanks @kolchfa-aws. LGTM!

Cc: @pajuric

@kolchfa-aws
Copy link
Collaborator

@pajuric Could you review/update the meta for this blog please?

Signed-off-by: kolchfa-aws <105444904+kolchfa-aws@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
new blog New blog post
Projects
Status: In Progress
Development

Successfully merging this pull request may close these issues.

6 participants