-
Notifications
You must be signed in to change notification settings - Fork 67
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
changes to merge PA-RTF #651
Conversation
Signed-off-by: Atharva Sharma <atharvasharma61@gmail.com>
Signed-off-by: Atharva Sharma <atharvasharma61@gmail.com>
Signed-off-by: Atharva Sharma <atharvasharma61@gmail.com>
Signed-off-by: Atharva Sharma <atharvasharma61@gmail.com>
Signed-off-by: Atharva Sharma <atharvasharma61@gmail.com>
https://pastecode.io/s/9bksb3ak |
Hi @atharvasharma61! This looks like an interesting change, do we have any rfc/doc to provide more context? |
Signed-off-by: Atharva Sharma <atharvasharma61@gmail.com>
Signed-off-by: Atharva Sharma <atharvasharma61@gmail.com>
Signed-off-by: Atharva Sharma <atharvasharma61@gmail.com>
Signed-off-by: Atharva Sharma <atharvasharma61@gmail.com>
Signed-off-by: Atharva Sharma <atharvasharma61@gmail.com>
Signed-off-by: Atharva Sharma <atharvasharma61@gmail.com>
Signed-off-by: Atharva Sharma <atharvasharma61@gmail.com>
src/main/java/org/opensearch/performanceanalyzer/PerformanceAnalyzerPlugin.java
Outdated
Show resolved
Hide resolved
src/main/java/org/opensearch/performanceanalyzer/PerformanceAnalyzerPlugin.java
Outdated
Show resolved
Hide resolved
src/main/java/org/opensearch/performanceanalyzer/collectors/ValueCalculator.java
Show resolved
Hide resolved
src/main/java/org/opensearch/performanceanalyzer/collectors/telemetry/RTFDisksCollector.java
Outdated
Show resolved
Hide resolved
src/main/java/org/opensearch/performanceanalyzer/collectors/telemetry/RTFDisksCollector.java
Outdated
Show resolved
Hide resolved
...ensearch/performanceanalyzer/collectors/telemetry/RTFNodeStatsAllShardsMetricsCollector.java
Outdated
Show resolved
Hide resolved
...ensearch/performanceanalyzer/collectors/telemetry/RTFNodeStatsAllShardsMetricsCollector.java
Show resolved
Hide resolved
...ensearch/performanceanalyzer/collectors/telemetry/RTFNodeStatsAllShardsMetricsCollector.java
Outdated
Show resolved
Hide resolved
...ensearch/performanceanalyzer/collectors/telemetry/RTFNodeStatsAllShardsMetricsCollector.java
Outdated
Show resolved
Hide resolved
src/test/java/org/opensearch/performanceanalyzer/PerformanceAnalyzerPluginTests.java
Show resolved
Hide resolved
Signed-off-by: Atharva Sharma <atharvasharma61@gmail.com>
Signed-off-by: Atharva Sharma <atharvasharma61@gmail.com>
...in/java/org/opensearch/performanceanalyzer/collectors/telemetry/RTFHeapMetricsCollector.java
Show resolved
Hide resolved
Signed-off-by: Atharva Sharma <atharvasharma61@gmail.com>
One more thing to call-out: We need to enable delta temporality in Opensearch Otel. @Gaganjuneja |
Signed-off-by: Atharva Sharma <atharvasharma61@gmail.com>
Signed-off-by: Atharva Sharma <atharvasharma61@gmail.com>
src/main/java/org/opensearch/performanceanalyzer/collectors/telemetry/RTFDisksCollector.java
Outdated
Show resolved
Hide resolved
src/main/java/org/opensearch/performanceanalyzer/collectors/telemetry/RTFDisksCollector.java
Show resolved
Hide resolved
Signed-off-by: Atharva Sharma <atharvasharma61@gmail.com>
Signed-off-by: Atharva Sharma <atharvasharma61@gmail.com>
Please take a look at build failures. |
Dependent on PRs: #657 and opensearch-project/performance-analyzer-commons#74 |
import org.opensearch.telemetry.metrics.MetricsRegistry; | ||
import org.opensearch.telemetry.metrics.tags.Tags; | ||
|
||
public class RTFDisksCollector extends PerformanceAnalyzerMetricsCollector |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
please add java doc on all collectors
src/main/java/org/opensearch/performanceanalyzer/collectors/telemetry/RTFDisksCollector.java
Show resolved
Hide resolved
Signed-off-by: Gagan Juneja <gjjuneja@amazon.com>
The backport to
To backport manually, run these commands in your terminal: # Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add .worktrees/backport-2.x 2.x
# Navigate to the new working tree
cd .worktrees/backport-2.x
# Create a new branch
git switch --create backport/backport-651-to-2.x
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 17611035b0519b96de809da2ccb07ea9b4107ede
# Push it to GitHub
git push --set-upstream origin backport/backport-651-to-2.x
# Go back to the original working tree
cd ../..
# Delete the working tree
git worktree remove .worktrees/backport-2.x Then, create a pull request where the |
* PA RTF merging init Signed-off-by: Atharva Sharma <atharvasharma61@gmail.com> * working model Signed-off-by: Atharva Sharma <atharvasharma61@gmail.com> * working model tip Signed-off-by: Atharva Sharma <atharvasharma61@gmail.com> * functional model init Signed-off-by: Atharva Sharma <atharvasharma61@gmail.com> * Migrated HeapMetricsCollector Signed-off-by: Atharva Sharma <atharvasharma61@gmail.com> * Added RTFThreadPoolMetricsCollector Signed-off-by: Atharva Sharma <atharvasharma61@gmail.com> * migrated NodeStats and DiskMetricsCollector Signed-off-by: Atharva Sharma <atharvasharma61@gmail.com> * Added gauge data model for Heap_Max metric Signed-off-by: Atharva Sharma <atharvasharma61@gmail.com> * implemented TelemetryAwarePlugin Signed-off-by: Atharva Sharma <atharvasharma61@gmail.com> * Framework changes for PA RTF merging Signed-off-by: Atharva Sharma <atharvasharma61@gmail.com> * refactored Signed-off-by: Atharva Sharma <atharvasharma61@gmail.com> * spotless applied Signed-off-by: Atharva Sharma <atharvasharma61@gmail.com> * Addressed small comments Signed-off-by: Atharva Sharma <atharvasharma61@gmail.com> * Added different flag for RCA collectors Signed-off-by: Atharva Sharma <atharvasharma61@gmail.com> * Addressed more comments Signed-off-by: Atharva Sharma <atharvasharma61@gmail.com> * Added RTF collectors in config map Signed-off-by: Atharva Sharma <atharvasharma61@gmail.com> * Added UTs Signed-off-by: Atharva Sharma <atharvasharma61@gmail.com> * Added further UTs Signed-off-by: Atharva Sharma <atharvasharma61@gmail.com> * Added dynamic control support to all collectors Signed-off-by: Atharva Sharma <atharvasharma61@gmail.com> * fixed UT Signed-off-by: Atharva Sharma <atharvasharma61@gmail.com> * refactoring Signed-off-by: Atharva Sharma <atharvasharma61@gmail.com> * Revert "refactoring" This reverts commit 25d66e8. Signed-off-by: Atharva Sharma <atharvasharma61@gmail.com> * Revert "fixed UT" This reverts commit 369bd95. Signed-off-by: Atharva Sharma <atharvasharma61@gmail.com> * Revert "Added dynamic control support to all collectors" This reverts commit 447e15f. Signed-off-by: Atharva Sharma <atharvasharma61@gmail.com> * Adding two new collector interfaces Signed-off-by: Atharva Sharma <atharvasharma61@gmail.com> * simplified interfaces Signed-off-by: Atharva Sharma <atharvasharma61@gmail.com> * Added units and javadocs Signed-off-by: Atharva Sharma <atharvasharma61@gmail.com> * Changes metrics semantic conventions Signed-off-by: Atharva Sharma <atharvasharma61@gmail.com> * refactored Signed-off-by: Atharva Sharma <atharvasharma61@gmail.com> * fixed UT Signed-off-by: Atharva Sharma <atharvasharma61@gmail.com> * Added stats metrics for rtf collectors Signed-off-by: Atharva Sharma <atharvasharma61@gmail.com> * reverted test delete Signed-off-by: Atharva Sharma <atharvasharma61@gmail.com> * Fixes javadoc compilation issue Signed-off-by: Gagan Juneja <gjjuneja@amazon.com> --------- Signed-off-by: Atharva Sharma <atharvasharma61@gmail.com> Signed-off-by: Gagan Juneja <gjjuneja@amazon.com> Co-authored-by: Gagan Juneja <gjjuneja@amazon.com>
* changes to merge PA-RTF (#651) * PA RTF merging init Signed-off-by: Atharva Sharma <atharvasharma61@gmail.com> * working model Signed-off-by: Atharva Sharma <atharvasharma61@gmail.com> * working model tip Signed-off-by: Atharva Sharma <atharvasharma61@gmail.com> * functional model init Signed-off-by: Atharva Sharma <atharvasharma61@gmail.com> * Migrated HeapMetricsCollector Signed-off-by: Atharva Sharma <atharvasharma61@gmail.com> * Added RTFThreadPoolMetricsCollector Signed-off-by: Atharva Sharma <atharvasharma61@gmail.com> * migrated NodeStats and DiskMetricsCollector Signed-off-by: Atharva Sharma <atharvasharma61@gmail.com> * Added gauge data model for Heap_Max metric Signed-off-by: Atharva Sharma <atharvasharma61@gmail.com> * implemented TelemetryAwarePlugin Signed-off-by: Atharva Sharma <atharvasharma61@gmail.com> * Framework changes for PA RTF merging Signed-off-by: Atharva Sharma <atharvasharma61@gmail.com> * refactored Signed-off-by: Atharva Sharma <atharvasharma61@gmail.com> * spotless applied Signed-off-by: Atharva Sharma <atharvasharma61@gmail.com> * Addressed small comments Signed-off-by: Atharva Sharma <atharvasharma61@gmail.com> * Added different flag for RCA collectors Signed-off-by: Atharva Sharma <atharvasharma61@gmail.com> * Addressed more comments Signed-off-by: Atharva Sharma <atharvasharma61@gmail.com> * Added RTF collectors in config map Signed-off-by: Atharva Sharma <atharvasharma61@gmail.com> * Added UTs Signed-off-by: Atharva Sharma <atharvasharma61@gmail.com> * Added further UTs Signed-off-by: Atharva Sharma <atharvasharma61@gmail.com> * Added dynamic control support to all collectors Signed-off-by: Atharva Sharma <atharvasharma61@gmail.com> * fixed UT Signed-off-by: Atharva Sharma <atharvasharma61@gmail.com> * refactoring Signed-off-by: Atharva Sharma <atharvasharma61@gmail.com> * Revert "refactoring" This reverts commit 25d66e8. Signed-off-by: Atharva Sharma <atharvasharma61@gmail.com> * Revert "fixed UT" This reverts commit 369bd95. Signed-off-by: Atharva Sharma <atharvasharma61@gmail.com> * Revert "Added dynamic control support to all collectors" This reverts commit 447e15f. Signed-off-by: Atharva Sharma <atharvasharma61@gmail.com> * Adding two new collector interfaces Signed-off-by: Atharva Sharma <atharvasharma61@gmail.com> * simplified interfaces Signed-off-by: Atharva Sharma <atharvasharma61@gmail.com> * Added units and javadocs Signed-off-by: Atharva Sharma <atharvasharma61@gmail.com> * Changes metrics semantic conventions Signed-off-by: Atharva Sharma <atharvasharma61@gmail.com> * refactored Signed-off-by: Atharva Sharma <atharvasharma61@gmail.com> * fixed UT Signed-off-by: Atharva Sharma <atharvasharma61@gmail.com> * Added stats metrics for rtf collectors Signed-off-by: Atharva Sharma <atharvasharma61@gmail.com> * reverted test delete Signed-off-by: Atharva Sharma <atharvasharma61@gmail.com> * Fixes javadoc compilation issue Signed-off-by: Gagan Juneja <gjjuneja@amazon.com> --------- Signed-off-by: Atharva Sharma <atharvasharma61@gmail.com> Signed-off-by: Gagan Juneja <gjjuneja@amazon.com> Co-authored-by: Gagan Juneja <gjjuneja@amazon.com> * Empty-Commit Signed-off-by: Dev Agarwal <devagarw@amazon.com> --------- Signed-off-by: Atharva Sharma <atharvasharma61@gmail.com> Signed-off-by: Gagan Juneja <gjjuneja@amazon.com> Signed-off-by: Dev Agarwal <devagarw@amazon.com> Co-authored-by: Atharva Sharma <60044988+atharvasharma61@users.noreply.github.com> Co-authored-by: Gagan Juneja <gjjuneja@amazon.com>
Implementation and extension of Issue: #585
Code changes w.r.t. merging PA with Open Telemetry
Changes:
Dependent Changes:
Commons-repo -> opensearch-project/performance-analyzer-commons#74
Is your feature request related to a problem? Please provide an existing Issue # , or describe.
A clear and concise description of what the problem is. Ex. I'm always frustrated when [...]
Describe the solution you are proposing
Describe alternatives you've considered
Additional context
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.