Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add workflow for gauntlet tests and fix spotbug errors #63

Merged
merged 5 commits into from
Sep 8, 2021

Conversation

sruti1312
Copy link
Contributor

@sruti1312 sruti1312 commented Sep 3, 2021

Is your feature request related to a problem? Please provide an existing Issue # , or describe.
#57
#65

Describe the solution you are proposing
Add workflow for gauntlet tests and fix spotbug errors

Describe alternatives you've considered
A clear and concise description of any alternative solutions or features you've considered.

Additional context
Add any other context or screenshots about the feature request here.

Check List

  • New functionality includes testing.
    • All tests pass
  • New functionality has been documented.
    • New functionality has javadoc added
  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@sruti1312 sruti1312 force-pushed the feature/gauntlet-tests branch from 1860492 to 7a09de0 Compare September 3, 2021 19:35
@codecov-commenter
Copy link

Codecov Report

Merging #63 (96ea949) into main (b7134db) will increase coverage by 1.51%.
The diff coverage is 62.19%.

❗ Current head 96ea949 differs from pull request most recent head 7a09de0. Consider uploading reports for the commit 7a09de0 to get more accurate results
Impacted file tree graph

@@             Coverage Diff              @@
##               main      #63      +/-   ##
============================================
+ Coverage     70.64%   72.15%   +1.51%     
- Complexity     2835     2927      +92     
============================================
  Files           371      371              
  Lines         18624    18624              
  Branches       1415     1415              
============================================
+ Hits          13156    13438     +282     
+ Misses         4895     4609     -286     
- Partials        573      577       +4     
Impacted Files Coverage Δ
...nalyzer/rca/configs/AdmissionControlRcaConfig.java 0.00% <0.00%> (ø)
...a/admissioncontrol/AdmissionControlClusterRca.java 100.00% <ø> (ø)
...ensearch/performanceanalyzer/util/range/Range.java 50.00% <0.00%> (ø)
...tore/rca/admissioncontrol/AdmissionControlRca.java 68.00% <56.00%> (ø)
.../decisionmaker/actions/AdmissionControlAction.java 81.81% <100.00%> (ø)
...ecisionmaker/deciders/AdmissionControlDecider.java 87.17% <100.00%> (ø)
...yzer/rca/framework/metrics/RcaVerticesMetrics.java 96.96% <100.00%> (ø)
...nceanalyzer/rca/store/OpenSearchAnalysisGraph.java 100.00% <100.00%> (ø)
.../util/range/RequestSizeHeapRangeConfiguration.java 88.23% <100.00%> (ø)
... and 26 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b7134db...7a09de0. Read the comment docs.

Signed-off-by: Sruti Parthiban <partsrut@amazon.com>
@sruti1312 sruti1312 force-pushed the feature/gauntlet-tests branch from 7a09de0 to 197367e Compare September 3, 2021 19:45
@sruti1312
Copy link
Contributor Author

Gauntlet tests are failing after the admission control changes are merged.
b7134db

Created an issue to track this: #65

sruti1312 and others added 4 commits September 7, 2021 13:13
Signed-off-by: Sruti Parthiban <partsrut@amazon.com>
Signed-off-by: Sruti Parthiban <partsrut@amazon.com>
Signed-off-by: Sruti Parthiban <partsrut@amazon.com>
Signed-off-by: Mital Awachat <awachatm@amazon.com>

Co-authored-by: Mital Awachat <awachatm@amazon.com>
@sruti1312 sruti1312 merged commit cdcae41 into main Sep 8, 2021
@sruti1312 sruti1312 deleted the feature/gauntlet-tests branch September 8, 2021 18:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants