Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixing Mockito initialization issue #443

Merged
merged 1 commit into from
Jul 10, 2023

Conversation

ansjcy
Copy link
Member

@ansjcy ansjcy commented Jul 10, 2023

Is your feature request related to a problem? Please provide an existing Issue # , or describe.
Currently a lot of unit tests are failing with error:

java.lang.NoClassDefFoundError: Could not initialize class org.mockito.Mockito

We need to fix the mockito-core version to 2.23.0.

reference: mockito/mockito#2568

Describe the solution you are proposing
A clear and concise description of what you want to happen.

Describe alternatives you've considered
A clear and concise description of any alternative solutions or features you've considered.

Additional context
Add any other context or screenshots about the feature request here.

Check List

  • New functionality includes testing.
    • All tests pass
  • New functionality has been documented.
    • New functionality has javadoc added
  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Signed-off-by: Chenyang Ji <cyji@amazon.com>
@codecov
Copy link

codecov bot commented Jul 10, 2023

Codecov Report

Merging #443 (6703758) into main (53e3b94) will decrease coverage by 0.06%.
The diff coverage is n/a.

❗ Current head 6703758 differs from pull request most recent head 1ffea86. Consider uploading reports for the commit 1ffea86 to get more accurate results

@@             Coverage Diff              @@
##               main     #443      +/-   ##
============================================
- Coverage     76.19%   76.13%   -0.06%     
+ Complexity     2604     2601       -3     
============================================
  Files           304      304              
  Lines         15577    15577              
  Branches       1219     1219              
============================================
- Hits          11869    11860       -9     
- Misses         3210     3217       +7     
- Partials        498      500       +2     

see 5 files with indirect coverage changes

@ansjcy ansjcy merged commit bb56be4 into opensearch-project:main Jul 10, 2023
opensearch-trigger-bot bot pushed a commit that referenced this pull request Jul 10, 2023
Signed-off-by: Chenyang Ji <cyji@amazon.com>
Co-authored-by: Chenyang Ji <cyji@amazon.com>
(cherry picked from commit bb56be4)
ansjcy added a commit that referenced this pull request Jul 10, 2023
Signed-off-by: Chenyang Ji <cyji@amazon.com>
Co-authored-by: Chenyang Ji <cyji@amazon.com>
(cherry picked from commit bb56be4)

Co-authored-by: Chenyang Ji <chenyang.yale@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants