Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove HeapAlloc_rate as HotShardRCA's upstream node. #411

Merged

Conversation

Tjofil
Copy link
Contributor

@Tjofil Tjofil commented Jun 8, 2023

#362

Check List

  • New functionality includes testing.
    • All tests pass
  • New functionality has been documented.
    • New functionality has javadoc added
  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Signed-off-by: Filip Drobnjakovic <drobnjakovicfilip@gmail.com>
@codecov
Copy link

codecov bot commented Jun 8, 2023

Codecov Report

Merging #411 (848bd6f) into main (515b35c) will decrease coverage by 0.13%.
The diff coverage is 50.00%.

❗ Current head 848bd6f differs from pull request most recent head 2ec1312. Consider uploading reports for the commit 2ec1312 to get more accurate results

@@             Coverage Diff              @@
##               main     #411      +/-   ##
============================================
- Coverage     76.08%   75.96%   -0.13%     
+ Complexity     2594     2580      -14     
============================================
  Files           302      302              
  Lines         15414    15357      -57     
  Branches       1216     1213       -3     
============================================
- Hits          11728    11666      -62     
- Misses         3191     3196       +5     
  Partials        495      495              
Impacted Files Coverage Δ
...analyzer/rca/configs/HotShardClusterRcaConfig.java 75.00% <ø> (-1.93%) ⬇️
...ormanceanalyzer/rca/configs/HotShardRcaConfig.java 76.92% <ø> (-0.86%) ⬇️
...r/rca/framework/api/summaries/HotShardSummary.java 83.49% <0.00%> (-0.99%) ⬇️
...zer/rca/store/rca/hotshard/HotShardClusterRca.java 85.22% <0.00%> (-3.44%) ⬇️
...nceanalyzer/rca/store/OpenSearchAnalysisGraph.java 100.00% <100.00%> (ø)
...ceanalyzer/rca/store/rca/hotshard/HotShardRca.java 84.95% <100.00%> (+1.25%) ⬆️

... and 6 files with indirect coverage changes

@khushbr khushbr merged commit 82a88ea into opensearch-project:main Jun 8, 2023
opensearch-trigger-bot bot pushed a commit that referenced this pull request Jun 8, 2023
Signed-off-by: Filip Drobnjakovic <drobnjakovicfilip@gmail.com>
(cherry picked from commit 82a88ea)
khushbr pushed a commit that referenced this pull request Jun 8, 2023
Signed-off-by: Filip Drobnjakovic <drobnjakovicfilip@gmail.com>
(cherry picked from commit 82a88ea)

Co-authored-by: Filip Drobnjaković <drobnjakovicfilip@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants