Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Swap jboss annotation dependency for jakarta annotations #407

Merged
merged 1 commit into from
Jun 7, 2023
Merged

Swap jboss annotation dependency for jakarta annotations #407

merged 1 commit into from
Jun 7, 2023

Conversation

Tjofil
Copy link
Contributor

@Tjofil Tjofil commented Jun 6, 2023

Due to PR on core.

Check List

  • New functionality includes testing.
    • All tests pass
  • New functionality has been documented.
    • New functionality has javadoc added
  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@Tjofil
Swap jboss annotation dependency in favor of jakarta.
c539b48 
Signed-off-by: Filip Drobnjakovic <drobnjakovicfilip@gmail.com>
@codecov
Copy link

codecov bot commented Jun 6, 2023

Codecov Report

Merging #407 (3870136) into main (066509d) will not change coverage.
The diff coverage is n/a.

❗ Current head 3870136 differs from pull request most recent head c539b48. Consider uploading reports for the commit c539b48 to get more accurate results

@@            Coverage Diff            @@
##               main     #407   +/-   ##
=========================================
  Coverage     76.08%   76.08%           
  Complexity     2595     2595           
=========================================
  Files           302      302           
  Lines         15414    15414           
  Branches       1216     1216           
=========================================
  Hits          11727    11727           
  Misses         3193     3193           
  Partials        494      494

@khushbr khushbr merged commit 515b35c into opensearch-project:main Jun 7, 2023
opensearch-trigger-bot bot pushed a commit that referenced this pull request Jun 7, 2023
@Tjofil @github-actions
Swap jboss annotation dependency in favor of jakarta. (#407)
b3f089d 
Signed-off-by: Filip Drobnjakovic <drobnjakovicfilip@gmail.com>
(cherry picked from commit 515b35c)
@opensearch-trigger-bot opensearch-trigger-bot bot mentioned this pull request Jun 7, 2023
Merged
khushbr pushed a commit that referenced this pull request Jun 28, 2023
@opensearch-trigger-bot @Tjofil
Swap jboss annotation dependency in favor of jakarta. (#407) (#409)
bcc6727 
Signed-off-by: Filip Drobnjakovic <drobnjakovicfilip@gmail.com>
(cherry picked from commit 515b35c)

Co-authored-by: Filip Drobnjaković <drobnjakovicfilip@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ansjcy ansjcy ansjcy approved these changes

@khushbr khushbr khushbr approved these changes

@praveensameneni praveensameneni Awaiting requested review from praveensameneni

@goyamegh goyamegh Awaiting requested review from goyamegh

@getsaurabh02 getsaurabh02 Awaiting requested review from getsaurabh02

@sbcd90 sbcd90 Awaiting requested review from sbcd90 sbcd90 is a code owner

@sgup432 sgup432 Awaiting requested review from sgup432

Assignees
No one assigned
Labels
backport 2.x
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Tjofil @ansjcy @khushbr