Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move collectors and their tests to Commons repo #378

Merged
merged 1 commit into from
May 26, 2023

Conversation

Tjofil
Copy link
Contributor

@Tjofil Tjofil commented May 26, 2023

Check List

  • New functionality includes testing.
    • All tests pass
  • New functionality has been documented.
    • New functionality has javadoc added
  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Signed-off-by: Filip Drobnjakovic <drobnjakovicfilip@gmail.com>
@codecov
Copy link

codecov bot commented May 26, 2023

Codecov Report

Merging #378 (d622759) into main (9d100f9) will increase coverage by 3.67%.
The diff coverage is 82.52%.

❗ Current head d622759 differs from pull request most recent head b5c7725. Consider uploading reports for the commit b5c7725 to get more accurate results

@@             Coverage Diff              @@
##               main     #378      +/-   ##
============================================
+ Coverage     72.40%   76.07%   +3.67%     
+ Complexity     2826     2610     -216     
============================================
  Files           348      307      -41     
  Lines         17443    15488    -1955     
  Branches       1398     1219     -179     
============================================
- Hits          12630    11783     -847     
+ Misses         4243     3209    -1034     
+ Partials        570      496      -74     
Impacted Files Coverage Δ
...zer/decisionmaker/deciders/CacheHealthDecider.java 80.59% <0.00%> (ø)
...rmanceanalyzer/decisionmaker/deciders/Decider.java 28.00% <0.00%> (ø)
...anceanalyzer/decisionmaker/deciders/Publisher.java 57.50% <0.00%> (ø)
...zer/decisionmaker/deciders/QueueHealthDecider.java 70.00% <0.00%> (ø)
...er/deciders/jvm/sizing/HeapSizeIncreasePolicy.java 14.51% <0.00%> (ø)
...arch/performanceanalyzer/metrics/ThreadIDUtil.java 0.00% <ø> (ø)
...performanceanalyzer/net/GRPCConnectionManager.java 82.41% <0.00%> (ø)
.../opensearch/performanceanalyzer/net/NetServer.java 68.67% <0.00%> (ø)
...h/performanceanalyzer/rca/RcaControllerHelper.java 60.97% <0.00%> (ø)
...alyzer/rca/framework/api/OpenSearchConfigNode.java 10.34% <0.00%> (ø)
... and 66 more

... and 1 file with indirect coverage changes

@khushbr khushbr merged commit d24214b into opensearch-project:main May 26, 2023
opensearch-trigger-bot bot pushed a commit that referenced this pull request May 30, 2023
Signed-off-by: Filip Drobnjakovic <drobnjakovicfilip@gmail.com>
(cherry picked from commit d24214b)
opensearch-trigger-bot bot pushed a commit that referenced this pull request May 30, 2023
Signed-off-by: Filip Drobnjakovic <drobnjakovicfilip@gmail.com>
(cherry picked from commit d24214b)
khushbr pushed a commit that referenced this pull request May 30, 2023
Signed-off-by: Filip Drobnjakovic <drobnjakovicfilip@gmail.com>
(cherry picked from commit d24214b)

Co-authored-by: Filip Drobnjaković <drobnjakovicfilip@gmail.com>
khushbr pushed a commit that referenced this pull request May 30, 2023
Signed-off-by: Filip Drobnjakovic <drobnjakovicfilip@gmail.com>
(cherry picked from commit d24214b)

Co-authored-by: Filip Drobnjaković <drobnjakovicfilip@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants