-
Notifications
You must be signed in to change notification settings - Fork 59
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Move collectors and their tests to Commons repo #378
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Filip Drobnjakovic <drobnjakovicfilip@gmail.com>
Codecov Report
@@ Coverage Diff @@
## main #378 +/- ##
============================================
+ Coverage 72.40% 76.07% +3.67%
+ Complexity 2826 2610 -216
============================================
Files 348 307 -41
Lines 17443 15488 -1955
Branches 1398 1219 -179
============================================
- Hits 12630 11783 -847
+ Misses 4243 3209 -1034
+ Partials 570 496 -74
|
khushbr
approved these changes
May 26, 2023
ansjcy
approved these changes
May 26, 2023
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
May 30, 2023
Signed-off-by: Filip Drobnjakovic <drobnjakovicfilip@gmail.com> (cherry picked from commit d24214b)
This was referenced May 30, 2023
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
May 30, 2023
Signed-off-by: Filip Drobnjakovic <drobnjakovicfilip@gmail.com> (cherry picked from commit d24214b)
khushbr
pushed a commit
that referenced
this pull request
May 30, 2023
khushbr
pushed a commit
that referenced
this pull request
May 30, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.