-
Notifications
You must be signed in to change notification settings - Fork 59
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
WriterMetrics and config classes removal #373
Conversation
Signed-off-by: Filip Drobnjakovic <drobnjakovicfilip@gmail.com>
Signed-off-by: Filip Drobnjakovic <drobnjakovicfilip@gmail.com>
Signed-off-by: Filip Drobnjakovic <drobnjakovicfilip@gmail.com>
Signed-off-by: Filip Drobnjakovic <drobnjakovicfilip@gmail.com>
Signed-off-by: Filip Drobnjakovic <drobnjakovicfilip@gmail.com>
Codecov Report
@@ Coverage Diff @@
## main #373 +/- ##
============================================
- Coverage 72.87% 72.41% -0.46%
+ Complexity 3045 2828 -217
============================================
Files 381 348 -33
Lines 19109 17443 -1666
Branches 1472 1398 -74
============================================
- Hits 13925 12632 -1293
+ Misses 4589 4242 -347
+ Partials 595 569 -26
|
@@ -346,11 +346,11 @@ dependencies { | |||
implementation 'org.checkerframework:checker-qual:3.29.0' | |||
implementation "com.fasterxml.jackson.core:jackson-annotations:${jacksonVersion}" | |||
implementation "com.fasterxml.jackson.core:jackson-databind:${jacksonDataBindVersion}" | |||
implementation "org.opensearch:performance-analyzer-commons:1.0.0-SNAPSHOT" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
1.0.0-SNAPSHOT
is meant for tracking active development and we use the release version otherwise.
Let us fix this in follow-up PR.
The backport to
To backport manually, run these commands in your terminal: # Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add .worktrees/backport-2.x 2.x
# Navigate to the new working tree
cd .worktrees/backport-2.x
# Create a new branch
git switch --create backport/backport-373-to-2.x
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 9d100f9766d2613ccbb9be07cbdf467332a22eea
# Push it to GitHub
git push --set-upstream origin backport/backport-373-to-2.x
# Go back to the original working tree
cd ../..
# Delete the working tree
git worktree remove .worktrees/backport-2.x Then, create a pull request where the |
* Replace majority of dependencies. Signed-off-by: Filip Drobnjakovic <drobnjakovicfilip@gmail.com> * Config folder removal and dependency redirection. Signed-off-by: Filip Drobnjakovic <drobnjakovicfilip@gmail.com> * Version dependency from commons. Signed-off-by: Filip Drobnjakovic <drobnjakovicfilip@gmail.com> * WriterMetrics removal and dependency redirection. Signed-off-by: Filip Drobnjakovic <drobnjakovicfilip@gmail.com> * Update with new commons dependency. Signed-off-by: Filip Drobnjakovic <drobnjakovicfilip@gmail.com> --------- Signed-off-by: Filip Drobnjakovic <drobnjakovicfilip@gmail.com> (cherry picked from commit 9d100f9)
* Replace majority of dependencies. Signed-off-by: Filip Drobnjakovic <drobnjakovicfilip@gmail.com> * Config folder removal and dependency redirection. Signed-off-by: Filip Drobnjakovic <drobnjakovicfilip@gmail.com> * Version dependency from commons. Signed-off-by: Filip Drobnjakovic <drobnjakovicfilip@gmail.com> * WriterMetrics removal and dependency redirection. Signed-off-by: Filip Drobnjakovic <drobnjakovicfilip@gmail.com> * Update with new commons dependency. Signed-off-by: Filip Drobnjakovic <drobnjakovicfilip@gmail.com> --------- Signed-off-by: Filip Drobnjakovic <drobnjakovicfilip@gmail.com> (cherry picked from commit 9d100f9) Co-authored-by: Filip Drobnjaković <drobnjakovicfilip@gmail.com>
* Replace majority of dependencies. Signed-off-by: Filip Drobnjakovic <drobnjakovicfilip@gmail.com> * Config folder removal and dependency redirection. Signed-off-by: Filip Drobnjakovic <drobnjakovicfilip@gmail.com> * Version dependency from commons. Signed-off-by: Filip Drobnjakovic <drobnjakovicfilip@gmail.com> * WriterMetrics removal and dependency redirection. Signed-off-by: Filip Drobnjakovic <drobnjakovicfilip@gmail.com> * Update with new commons dependency. Signed-off-by: Filip Drobnjakovic <drobnjakovicfilip@gmail.com> --------- Signed-off-by: Filip Drobnjakovic <drobnjakovicfilip@gmail.com> (cherry picked from commit 9d100f9)
* Replace majority of dependencies. Signed-off-by: Filip Drobnjakovic <drobnjakovicfilip@gmail.com> * Config folder removal and dependency redirection. Signed-off-by: Filip Drobnjakovic <drobnjakovicfilip@gmail.com> * Version dependency from commons. Signed-off-by: Filip Drobnjakovic <drobnjakovicfilip@gmail.com> * WriterMetrics removal and dependency redirection. Signed-off-by: Filip Drobnjakovic <drobnjakovicfilip@gmail.com> * Update with new commons dependency. Signed-off-by: Filip Drobnjakovic <drobnjakovicfilip@gmail.com> --------- Signed-off-by: Filip Drobnjakovic <drobnjakovicfilip@gmail.com> (cherry picked from commit 9d100f9) Co-authored-by: Filip Drobnjaković <drobnjakovicfilip@gmail.com>
Removed and redirect dependencies to commons for
WriterMetrics
and several config classes and sub-classes.Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.