-
Notifications
You must be signed in to change notification settings - Fork 59
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update Libraries to fetch the updated netty patched with CVE-2022-24823 #230
Update Libraries to fetch the updated netty patched with CVE-2022-24823 #230
Conversation
Signed-off-by: Kiran Prakash <awskiran@amazon.com>
Signed-off-by: Kiran Prakash <awskiran@amazon.com>
Codecov Report
@@ Coverage Diff @@
## main #230 +/- ##
============================================
- Coverage 71.62% 71.53% -0.09%
Complexity 2988 2988
============================================
Files 380 380
Lines 18952 18952
Branches 1463 1463
============================================
- Hits 13574 13558 -16
- Misses 4783 4799 +16
Partials 595 595
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
Signed-off-by: Kiran Prakash <awskiran@amazon.com>
Signed-off-by: Kiran Prakash <awskiran@amazon.com>
Signed-off-by: Kiran Prakash <awskiran@amazon.com>
Looks good to me. Will approve once you revert fork change. |
The backport to
To backport manually, run these commands in your terminal: # Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add .worktrees/backport-1.x 1.x
# Navigate to the new working tree
cd .worktrees/backport-1.x
# Create a new branch
git switch --create backport/backport-230-to-1.x
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 93c22e74e04c1ba635af7941a41b011beb3d15bf
# Push it to GitHub
git push --set-upstream origin backport/backport-230-to-1.x
# Go back to the original working tree
cd ../..
# Delete the working tree
git worktree remove .worktrees/backport-1.x Then, create a pull request where the |
… (opensearch-project#230) * update netty version Signed-off-by: Kiran Prakash <awskiran@amazon.com> * update netty version Signed-off-by: Kiran Prakash <awskiran@amazon.com> * update branch to the one in PA to get a green build Signed-off-by: Kiran Prakash <awskiran@amazon.com> * use the correct branch name Signed-off-by: Kiran Prakash <awskiran@amazon.com> * use the correct branch name Signed-off-by: Kiran Prakash <awskiran@amazon.com> Signed-off-by: Kiran Prakash <awskiran@amazon.com> (cherry picked from commit 93c22e7)
… (opensearch-project#230) * update netty version Signed-off-by: Kiran Prakash <awskiran@amazon.com> * update netty version Signed-off-by: Kiran Prakash <awskiran@amazon.com> * update branch to the one in PA to get a green build Signed-off-by: Kiran Prakash <awskiran@amazon.com> * use the correct branch name Signed-off-by: Kiran Prakash <awskiran@amazon.com> * use the correct branch name Signed-off-by: Kiran Prakash <awskiran@amazon.com> Signed-off-by: Kiran Prakash <awskiran@amazon.com> (cherry picked from commit 93c22e7)
… (opensearch-project#230) * update netty version Signed-off-by: Kiran Prakash <awskiran@amazon.com> * update netty version Signed-off-by: Kiran Prakash <awskiran@amazon.com> * update branch to the one in PA to get a green build Signed-off-by: Kiran Prakash <awskiran@amazon.com> * use the correct branch name Signed-off-by: Kiran Prakash <awskiran@amazon.com> * use the correct branch name Signed-off-by: Kiran Prakash <awskiran@amazon.com> Signed-off-by: Kiran Prakash <awskiran@amazon.com> (cherry picked from commit 93c22e7)
The backport to
To backport manually, run these commands in your terminal: # Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add .worktrees/backport-2.3 2.3
# Navigate to the new working tree
cd .worktrees/backport-2.3
# Create a new branch
git switch --create backport/backport-230-to-2.3
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 93c22e74e04c1ba635af7941a41b011beb3d15bf
# Push it to GitHub
git push --set-upstream origin backport/backport-230-to-2.3
# Go back to the original working tree
cd ../..
# Delete the working tree
git worktree remove .worktrees/backport-2.3 Then, create a pull request where the |
The backport to
To backport manually, run these commands in your terminal: # Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add .worktrees/backport-1.3 1.3
# Navigate to the new working tree
cd .worktrees/backport-1.3
# Create a new branch
git switch --create backport/backport-230-to-1.3
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 93c22e74e04c1ba635af7941a41b011beb3d15bf
# Push it to GitHub
git push --set-upstream origin backport/backport-230-to-1.3
# Go back to the original working tree
cd ../..
# Delete the working tree
git worktree remove .worktrees/backport-1.3 Then, create a pull request where the |
The backport to
To backport manually, run these commands in your terminal: # Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add .worktrees/backport-2.x 2.x
# Navigate to the new working tree
cd .worktrees/backport-2.x
# Create a new branch
git switch --create backport/backport-230-to-2.x
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 93c22e74e04c1ba635af7941a41b011beb3d15bf
# Push it to GitHub
git push --set-upstream origin backport/backport-230-to-2.x
# Go back to the original working tree
cd ../..
# Delete the working tree
git worktree remove .worktrees/backport-2.x Then, create a pull request where the |
* Update Libraries to fetch the updated netty patched with CVE-2022-24823 (#230) Signed-off-by: Kiran Prakash <awskiran@amazon.com> (cherry picked from commit 93c22e7)
Signed-off-by: Kiran Prakash awskiran@amazon.com
Is your feature request related to a problem? Please provide an existing Issue # , or describe.
netty had a CVE-2022-24823 that was patched in 4.1.77.Final
PA RCA uses netty via grpc which updated the netty to 4.1.77.Final in 1.49.0
For a green build - This is building off Performance Analyzer against my
fork - kiranprakash154/performance-analyzer
branch - kiranprakash154:kp/update-netty-json
Next Steps:
Describe the solution you are proposing
Update grpc version from 1.44.0 to 1.49.0
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.