-
Notifications
You must be signed in to change notification settings - Fork 59
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upgrade grpc-netty version to 1.42.2 #115
Conversation
Signed-off-by: Sruti Parthiban <partsrut@amazon.com>
Codecov Report
@@ Coverage Diff @@
## 1.2 #115 +/- ##
============================================
+ Coverage 71.98% 72.03% +0.05%
- Complexity 2941 2945 +4
============================================
Files 376 376
Lines 18723 18723
Branches 1432 1432
============================================
+ Hits 13477 13488 +11
+ Misses 4662 4648 -14
- Partials 584 587 +3
Continue to review full report at Codecov.
|
dcef463
to
6764e57
Compare
Signed-off-by: Sruti Parthiban <partsrut@amazon.com>
6764e57
to
f8ebcc4
Compare
Could use grpc-netty instead of grpc-netty-shaded? |
Signed-off-by: sruti1312 <srutiparthiban@gmail.com>
2a17f6b
to
7748f9c
Compare
Created an issue to track using |
* Upgrade grpc-netty version Signed-off-by: Sruti Parthiban <partsrut@amazon.com> * Add classes to exlude in findbugs Signed-off-by: Sruti Parthiban <partsrut@amazon.com> * Upgrade protobuf version Signed-off-by: sruti1312 <srutiparthiban@gmail.com>
* Upgrade grpc-netty version Signed-off-by: Sruti Parthiban <partsrut@amazon.com> * Add classes to exlude in findbugs Signed-off-by: Sruti Parthiban <partsrut@amazon.com> * Upgrade protobuf version Signed-off-by: sruti1312 <srutiparthiban@gmail.com>
This reverts commit eeafdf5.
This reverts commit eeafdf5. Signed-off-by: sruti1312 <srutiparthiban@gmail.com>
Signed-off-by: Sruti Parthiban partsrut@amazon.com
Is your feature request related to a problem? Please provide an existing Issue # , or describe.
A clear and concise description of what the problem is. Ex. I'm always frustrated when [...]
Describe the solution you are proposing
Upgrade grpc-netty version to
1.42.2
- which upgrades netty-codec to4.1.63.Final
Describe alternatives you've considered
A clear and concise description of any alternative solutions or features you've considered.
Additional context
Add any other context or screenshots about the feature request here.
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.