Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade grpc-netty version to 1.42.2 #115

Merged
merged 3 commits into from
Jan 24, 2022
Merged

Upgrade grpc-netty version to 1.42.2 #115

merged 3 commits into from
Jan 24, 2022

Conversation

sruti1312
Copy link
Contributor

@sruti1312 sruti1312 commented Jan 14, 2022

Signed-off-by: Sruti Parthiban partsrut@amazon.com

Is your feature request related to a problem? Please provide an existing Issue # , or describe.
A clear and concise description of what the problem is. Ex. I'm always frustrated when [...]

Describe the solution you are proposing
Upgrade grpc-netty version to 1.42.2 - which upgrades netty-codec to 4.1.63.Final

Describe alternatives you've considered
A clear and concise description of any alternative solutions or features you've considered.

Additional context
Add any other context or screenshots about the feature request here.

Check List

  • New functionality includes testing.
    • All tests pass
  • New functionality has been documented.
    • New functionality has javadoc added
  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Signed-off-by: Sruti Parthiban <partsrut@amazon.com>
@codecov-commenter
Copy link

codecov-commenter commented Jan 14, 2022

Codecov Report

Merging #115 (d45ca61) into 1.2 (d81f066) will increase coverage by 0.05%.
The diff coverage is n/a.

❗ Current head d45ca61 differs from pull request most recent head 2a17f6b. Consider uploading reports for the commit 2a17f6b to get more accurate results
Impacted file tree graph

@@             Coverage Diff              @@
##                1.2     #115      +/-   ##
============================================
+ Coverage     71.98%   72.03%   +0.05%     
- Complexity     2941     2945       +4     
============================================
  Files           376      376              
  Lines         18723    18723              
  Branches       1432     1432              
============================================
+ Hits          13477    13488      +11     
+ Misses         4662     4648      -14     
- Partials        584      587       +3     
Impacted Files Coverage Δ
...performanceanalyzer/collectors/StatsCollector.java 93.23% <0.00%> (+0.75%) ⬆️
...ensearch/performanceanalyzer/hwnet/NetworkE2E.java 79.27% <0.00%> (+1.80%) ⬆️
...nalyzer/rca/net/handler/PublishRequestHandler.java 82.92% <0.00%> (+4.87%) ⬆️
...formanceanalyzer/PerformanceAnalyzerWebServer.java 74.62% <0.00%> (+5.97%) ⬆️
...performanceanalyzer/rca/framework/api/Symptom.java 100.00% <0.00%> (+9.09%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d81f066...2a17f6b. Read the comment docs.

@sruti1312 sruti1312 force-pushed the feature/upgrade-netty branch 6 times, most recently from dcef463 to 6764e57 Compare January 14, 2022 22:57
Signed-off-by: Sruti Parthiban <partsrut@amazon.com>
@sruti1312 sruti1312 force-pushed the feature/upgrade-netty branch from 6764e57 to f8ebcc4 Compare January 15, 2022 00:28
@kenlee1988
Copy link

kenlee1988 commented Jan 20, 2022

Could use grpc-netty instead of grpc-netty-shaded?
This allows you to set up and upgrade netty‘s version separately
netty 4.1.63.Final still have many Vulnerabilities

Signed-off-by: sruti1312 <srutiparthiban@gmail.com>
@sruti1312 sruti1312 force-pushed the feature/upgrade-netty branch from 2a17f6b to 7748f9c Compare January 21, 2022 23:09
@sruti1312
Copy link
Contributor Author

Could use grpc-netty instead of grpc-netty-shaded? This allows you to set up and upgrade netty‘s version separately netty 4.1.63.Final still have many Vulnerabilities

Created an issue to track using grpc-netty instead of grpc-netty-shaded. Merging in this PR as it helps address other potential vulnerabilities.
#119

@sruti1312 sruti1312 merged commit eeafdf5 into 1.2 Jan 24, 2022
@sruti1312 sruti1312 deleted the feature/upgrade-netty branch January 24, 2022 19:16
@sruti1312 sruti1312 restored the feature/upgrade-netty branch January 24, 2022 19:17
@sruti1312 sruti1312 deleted the feature/upgrade-netty branch January 24, 2022 19:17
sruti1312 added a commit that referenced this pull request Jan 24, 2022
* Upgrade grpc-netty version

Signed-off-by: Sruti Parthiban <partsrut@amazon.com>

* Add classes to exlude in findbugs

Signed-off-by: Sruti Parthiban <partsrut@amazon.com>

* Upgrade protobuf version

Signed-off-by: sruti1312 <srutiparthiban@gmail.com>
sruti1312 added a commit that referenced this pull request Jan 24, 2022
* Upgrade grpc-netty version

Signed-off-by: Sruti Parthiban <partsrut@amazon.com>

* Add classes to exlude in findbugs

Signed-off-by: Sruti Parthiban <partsrut@amazon.com>

* Upgrade protobuf version

Signed-off-by: sruti1312 <srutiparthiban@gmail.com>
sruti1312 added a commit that referenced this pull request Jan 24, 2022
sruti1312 added a commit that referenced this pull request Jan 24, 2022
This reverts commit eeafdf5.

Signed-off-by: sruti1312 <srutiparthiban@gmail.com>
sruti1312 added a commit that referenced this pull request Jan 24, 2022
This reverts commit eeafdf5.

Signed-off-by: sruti1312 <srutiparthiban@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants