Upgrade plugin version to 1.2.4 and log4j to 2.17.1 #112
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Karishma Joseph <karisjos@amazon.com>
Codecov Report
@@ Coverage Diff @@
## 1.2 #112 +/- ##
============================================
+ Coverage 72.01% 72.05% +0.03%
- Complexity 2943 2944 +1
============================================
Files 376 376
Lines 18723 18723
Branches 1432 1432
============================================
+ Hits 13484 13490 +6
+ Misses 4651 4645 -6
Partials 588 588
Continue to review full report at Codecov.
|
|
Can we please prioritize #107? |
sruti1312
approved these changes
Jan 4, 2022
kkhatua
approved these changes
Jan 4, 2022
Looks like in this case, the CI was failing because the version of PA that it was checking out was still using 2.17.0. Once the PR to upgrade PA to use 2.17.1 version of log4j was merged in, the CI passes. |
|
@kjoseph07 Thanks. Please port this change to main and increment that version to 1.3.0. |
38 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Karishma Joseph karisjos@amazon.com
Is your feature request related to a problem? Please provide an existing Issue # , or describe.
#110
Describe the solution you are proposing
A clear and concise description of what you want to happen.
Describe alternatives you've considered
A clear and concise description of any alternative solutions or features you've considered.
Additional context
Add any other context or screenshots about the feature request here.
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.