Replace Avatar in favor of Icon in OuiFacetButtons example #987
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…h-project#909) Signed-off-by: Danila Gulderov <danila@gulderov.me>
gulderov
requested review from
seanneumann,
AMoo-Miki,
rednaksi91,
KrooshalUX,
BSFishy,
bandinib-amzn,
ashwin-pc,
joshuarrrr,
andreymyssak and
SergeyMyssak
as code owners
Signed-off-by: Danila Gulderov <danila@gulderov.me>
BSFishy
approved these changes
Aug 24, 2023
|
@KrooshalUX Can you approve screenshot is what you were looking for? |
|
@joshuarrrr LGTM |
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Sep 1, 2023
* Replace Avatar in favor of Icon in OuiFacetButtons example (#909) Signed-off-by: Danila Gulderov <danila@gulderov.me> * changelog update (#909) Signed-off-by: Danila Gulderov <danila@gulderov.me> --------- Signed-off-by: Danila Gulderov <danila@gulderov.me> (cherry picked from commit 36cb2a8) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> # Conflicts: # CHANGELOG.md
AMoo-Miki
pushed a commit
that referenced
this pull request
Sep 1, 2023
) * Replace Avatar in favor of Icon in OuiFacetButtons example (#909) Signed-off-by: Danila Gulderov <danila@gulderov.me> * changelog update (#909) Signed-off-by: Danila Gulderov <danila@gulderov.me> --------- Signed-off-by: Danila Gulderov <danila@gulderov.me> (cherry picked from commit 36cb2a8) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> # Conflicts: # CHANGELOG.md Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Update "avatar as icon" example as described in #909
Issues Resolved
Closes #909
Check List
yarn lintyarn test-unitBy submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.