Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[OUI Docs] Updated the logo to logoOpenSearch #315

Merged
merged 4 commits into from
Feb 28, 2023

Conversation

AbhishekReddy1127
Copy link
Contributor

Description

Updated the logoElastic to LogoOpensearch in the section A full page with evreything.
Screenshot 2023-02-17 at 1 50 10 PM

Issues Resolved

#177

Check List

  • New functionality includes testing.
  • New functionality has been documented.
  • All tests pass
    • yarn lint
    • yarn test-unit
  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@BSFishy
Copy link
Contributor

BSFishy commented Feb 20, 2023

This might be blocked until we actually add the OpenSearch icon to OUI. Doesn't make sense having an empty icon on the doc site

Signed-off-by: AbhishekReddy1127 <nallamsa@amazon.com>
@kgcreative
Copy link
Member

For now, can we add it as a one-off SVG? I thought OUIicon allows for you to do that.

@BSFishy
Copy link
Contributor

BSFishy commented Feb 20, 2023

I think dependency should just be denoted by a comment and blocked label. Just until we get the icon. I think we could just add it in a separate PR, as a one off thing like @kgcreative mentioned, but until then I don't think we should merge this one

@KrooshalUX KrooshalUX linked an issue Feb 21, 2023 that may be closed by this pull request
2 tasks
@KrooshalUX
Copy link
Contributor

blocked by #369

Copy link
Contributor

@BSFishy BSFishy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Blocking PR has been merged

Copy link
Contributor

@seanneumann seanneumann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@seanneumann seanneumann merged commit aa2937e into opensearch-project:main Feb 28, 2023
opensearch-trigger-bot bot pushed a commit that referenced this pull request Apr 14, 2023
Signed-off-by: AbhishekReddy1127 <nallamsa@amazon.com>
Co-authored-by: Sean Neumann <1413295+seanneumann@users.noreply.github.com>
(cherry picked from commit aa2937e)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
opensearch-trigger-bot bot pushed a commit that referenced this pull request Apr 14, 2023
Signed-off-by: AbhishekReddy1127 <nallamsa@amazon.com>
Co-authored-by: Sean Neumann <1413295+seanneumann@users.noreply.github.com>
(cherry picked from commit aa2937e)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
opensearch-trigger-bot bot pushed a commit that referenced this pull request Apr 14, 2023
Signed-off-by: AbhishekReddy1127 <nallamsa@amazon.com>
Co-authored-by: Sean Neumann <1413295+seanneumann@users.noreply.github.com>
(cherry picked from commit aa2937e)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
BSFishy pushed a commit that referenced this pull request May 10, 2023
(cherry picked from commit aa2937e)

Signed-off-by: AbhishekReddy1127 <nallamsa@amazon.com>
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: Sean Neumann <1413295+seanneumann@users.noreply.github.com>
ashwin-pc pushed a commit that referenced this pull request May 25, 2023
(cherry picked from commit aa2937e)

Signed-off-by: AbhishekReddy1127 <nallamsa@amazon.com>
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: Sean Neumann <1413295+seanneumann@users.noreply.github.com>
AMoo-Miki pushed a commit that referenced this pull request Jun 20, 2023
(cherry picked from commit aa2937e)

Signed-off-by: AbhishekReddy1127 <nallamsa@amazon.com>
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: Sean Neumann <1413295+seanneumann@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

(OUI Docs) Page
5 participants