Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Additional updates to v9 theme #1417

Merged
merged 1 commit into from
Sep 26, 2024

Conversation

virajsanghvi
Copy link
Collaborator

@virajsanghvi virajsanghvi commented Sep 26, 2024

Description

Updates to v9 theme - dark theme colors still to be updated.

New:

  • Additional borderRadius sizes on Panels (might be used in osd)
  • Configuration of borderRadius on Cards (might be used in osd)
  • Make Side Nav variables themeable
  • Make Links use font-weight $ouiFontWeightSemiBold (no change for existing themes)
  • Make input group radius match input radius using variable

V9 updates:

  • Make buttons (except icon button) have a background color (old themes use transparent)
    • UX was okay with some instances of icon buttons next to regular buttons with mixed backgrounds
  • Switch back to buttons having 4px radius
  • Using 0 border radius for inputs
  • Update light theme colors
  • Make Links use a lower font-weight
  • Adjust typography size + weight

Screenshots (v7 should have no changes below)

Item Before (v9) After (v9) Before (v7) After (v7)
V9 Colors image image
V9 Typography image image
EuiLink image image image image
Panel borderRadius image
Card borderRadius image
Side nav selected item image image
Input border radius image image
Buttons image image image image
Ghost Buttons image image image image
Split Buttons image image image image

Issues Resolved

N/A

Check List

  • New functionality includes testing.
  • New functionality has been documented.
  • All tests pass
    • yarn lint
    • yarn test-unit
  • Update CHANGELOG.md
  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

For more information on following Developer Certificate of Origin and signing off your commits, please check here.

$ouiFontWeightRegular: 300 !default;
$ouiFontWeightMedium: 400 !default;
$ouiFontWeightLight: 400 !default;
$ouiFontWeightRegular: 400 !default;
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

😭

- Additional borderRadius sizes on Panels
- Configuration of borderRadius on Cards
- Make Side Nav variables themeable
- Make Links use font-weight `$ouiFontWeightSemiBold`
- Enable themes to define background colors for Buttons

Signed-off-by: Viraj Sanghvi <virajs@amazon.com>
@AMoo-Miki AMoo-Miki merged commit 18ed6db into opensearch-project:main Sep 26, 2024
14 checks passed
opensearch-trigger-bot bot pushed a commit that referenced this pull request Sep 26, 2024
- Additional borderRadius sizes on Panels
- Configuration of borderRadius on Cards
- Make Side Nav variables themeable
- Make Links use font-weight `$ouiFontWeightSemiBold`
- Enable themes to define background colors for Buttons

Signed-off-by: Viraj Sanghvi <virajs@amazon.com>
(cherry picked from commit 18ed6db)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>

# Conflicts:
#	CHANGELOG.md
virajsanghvi pushed a commit that referenced this pull request Sep 26, 2024
- Additional borderRadius sizes on Panels
- Configuration of borderRadius on Cards
- Make Side Nav variables themeable
- Make Links use font-weight `$ouiFontWeightSemiBold`
- Enable themes to define background colors for Buttons

Signed-off-by: Viraj Sanghvi <virajs@amazon.com>
(cherry picked from commit 18ed6db)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>

# Conflicts:
#	CHANGELOG.md

Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants