-
Notifications
You must be signed in to change notification settings - Fork 70
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Additional updates to v9 theme #1417
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
virajsanghvi
force-pushed
the
v9-updates-3
branch
2 times, most recently
from
September 26, 2024 17:06
0b1e763
to
f51271f
Compare
virajsanghvi
requested review from
AMoo-Miki,
bandinib-amzn,
ashwin-pc and
joshuarrrr
as code owners
September 26, 2024 17:40
AMoo-Miki
reviewed
Sep 26, 2024
$ouiFontWeightRegular: 300 !default; | ||
$ouiFontWeightMedium: 400 !default; | ||
$ouiFontWeightLight: 400 !default; | ||
$ouiFontWeightRegular: 400 !default; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
😭
AMoo-Miki
approved these changes
Sep 26, 2024
AMoo-Miki
reviewed
Sep 26, 2024
AMoo-Miki
reviewed
Sep 26, 2024
- Additional borderRadius sizes on Panels - Configuration of borderRadius on Cards - Make Side Nav variables themeable - Make Links use font-weight `$ouiFontWeightSemiBold` - Enable themes to define background colors for Buttons Signed-off-by: Viraj Sanghvi <virajs@amazon.com>
virajsanghvi
force-pushed
the
v9-updates-3
branch
from
September 26, 2024 18:21
f51271f
to
3a6177e
Compare
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Sep 26, 2024
- Additional borderRadius sizes on Panels - Configuration of borderRadius on Cards - Make Side Nav variables themeable - Make Links use font-weight `$ouiFontWeightSemiBold` - Enable themes to define background colors for Buttons Signed-off-by: Viraj Sanghvi <virajs@amazon.com> (cherry picked from commit 18ed6db) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> # Conflicts: # CHANGELOG.md
virajsanghvi
pushed a commit
that referenced
this pull request
Sep 26, 2024
- Additional borderRadius sizes on Panels - Configuration of borderRadius on Cards - Make Side Nav variables themeable - Make Links use font-weight `$ouiFontWeightSemiBold` - Enable themes to define background colors for Buttons Signed-off-by: Viraj Sanghvi <virajs@amazon.com> (cherry picked from commit 18ed6db) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> # Conflicts: # CHANGELOG.md Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Updates to v9 theme - dark theme colors still to be updated.
New:
$ouiFontWeightSemiBold
(no change for existing themes)V9 updates:
Screenshots (v7 should have no changes below)
Issues Resolved
N/A
Check List
yarn lint
yarn test-unit
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.