Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add workspace icons #1365

Merged
merged 1 commit into from
Aug 21, 2024
Merged

Conversation

AMoo-Miki
Copy link
Collaborator

Description

Add 6 workspace icons

Check List

  • New functionality includes testing.
  • New functionality has been documented.
  • All tests pass
    • yarn lint
    • yarn test-unit
  • Update CHANGELOG.md
  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Copy link
Collaborator

@virajsanghvi virajsanghvi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

are lint/test failures expected?

Also:
* Synced CHANGELOG.md

Signed-off-by: Miki <miki@amazon.com>
@AMoo-Miki
Copy link
Collaborator Author

are lint/test failures expected?

No. Fixed.

Copy link
Collaborator

@virajsanghvi virajsanghvi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

approving assuming lint/test failures pass with changes

@AMoo-Miki AMoo-Miki merged commit cf9cf4a into opensearch-project:main Aug 21, 2024
13 of 14 checks passed
opensearch-trigger-bot bot pushed a commit that referenced this pull request Aug 21, 2024
Also:
* Synced CHANGELOG.md

Signed-off-by: Miki <miki@amazon.com>
(cherry picked from commit cf9cf4a)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>

# Conflicts:
#	CHANGELOG.md
AMoo-Miki pushed a commit that referenced this pull request Aug 21, 2024
Also:
* Synced CHANGELOG.md

Signed-off-by: Miki <miki@amazon.com>
(cherry picked from commit cf9cf4a)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>

# Conflicts:
#	CHANGELOG.md

Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants