-
Notifications
You must be signed in to change notification settings - Fork 70
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Optimize calc() usage in scss files #1158
Open
ShatilKhan
wants to merge
17
commits into
opensearch-project:main
Choose a base branch
from
ShatilKhan:calc
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Commits on Nov 16, 2023
-
Update README.md (opensearch-project#570)
Signed-off-by: Nuraiym Omurbekova <nuraikaomurbek@gmail.com> Co-authored-by: Josh Romero <rmerqg@amazon.com> Signed-off-by: ShatilKhan <shatilshahriar009@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for 1dcc096 - Browse repository at this point
Copy the full SHA 1dcc096View commit details
Commits on Nov 17, 2023
-
Replace
node-sass
withsass-embedded
(opensearch-project#1001)Also: * Implement sass variable extraction * Implement sass variable importing in typescript * Add guards to post-install cleanup * Make sources compatible with dart sass by wrapping divisions in `calc()` and adding units were necessary * Fold in `@elastic/charts/dist/theme.scss` to modify it for dart-sass compatibility * Break out compiling `charts` Signed-off-by: Miki <miki@amazon.com> Signed-off-by: ShatilKhan <shatilshahriar009@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for 150eb7d - Browse repository at this point
Copy the full SHA 150eb7dView commit details -
Bump typescript to 4.6.4 (opensearch-project#879)
* typescript bump: 4.1.6 Signed-off-by: Danila Gulderov <danila@gulderov.me> * typescript bump: 4.2.4 Signed-off-by: Danila Gulderov <danila@gulderov.me> * typescript bump: 4.3.5 Signed-off-by: Danila Gulderov <danila@gulderov.me> * typescript bump: 4.4.4 Signed-off-by: Danila Gulderov <danila@gulderov.me> * typescript bump: 4.5.5 Signed-off-by: Danila Gulderov <danila@gulderov.me> * typescript bump: 4.6.4 Signed-off-by: Danila Gulderov <danila@gulderov.me> * CHANGELOG.md updated Signed-off-by: Danila Gulderov <danila@gulderov.me> * bump typescript-eslint/eslint-plugin: 5.62.0 bump typescript-eslint/parser: 5.62.0 node 16 is required for typescript-eslint: 6.0.0 Signed-off-by: Danila Gulderov <danila@gulderov.me> * CHANGELOG.md update Signed-off-by: Danila Gulderov <danila@gulderov.me> * move typescript update to regular section Signed-off-by: Danila Gulderov <danila@gulderov.me> * changelog message improvement Signed-off-by: Danila Gulderov <danila@gulderov.me> * fix typings Signed-off-by: Danila Gulderov <danila@gulderov.me> * cleanup useUnknownInCatchVariables Signed-off-by: Danila Gulderov <danila@gulderov.me> * logical or => nullish coalescing Signed-off-by: Danila Gulderov <danila@gulderov.me> * wrap with String Signed-off-by: Danila Gulderov <danila@gulderov.me> * Update CHANGELOG.md Move CHANGELOG entry to the unreleased section Signed-off-by: Miki <miki@amazon.com> * Add back `onPinClick` check in `OuiPinnableListGroup` Update pinnable_list_group.tsx Signed-off-by: Miki <miki@amazon.com> * Enhance error message extraction in `validateFieldValue` Update default_syntax.ts Signed-off-by: Miki <miki@amazon.com> * Remove e.code from default_syntax.ts Update default_syntax.ts Signed-off-by: Miki <miki@amazon.com> * Lint default_syntax.ts Signed-off-by: Miki <miki@amazon.com> --------- Signed-off-by: Danila Gulderov <danila@gulderov.me> Signed-off-by: Matt Provost <provomat@amazon.com> Signed-off-by: Miki <miki@amazon.com> Co-authored-by: Matt Provost <provomat@amazon.com> Co-authored-by: Josh Romero <rmerqg@amazon.com> Co-authored-by: Miki <miki@amazon.com> Signed-off-by: ShatilKhan <shatilshahriar009@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for d07d137 - Browse repository at this point
Copy the full SHA d07d137View commit details -
Signed-off-by: Shahriar Shatil <52494840+ShatilKhan@users.noreply.github.com> Signed-off-by: ShatilKhan <shatilshahriar009@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for 2059084 - Browse repository at this point
Copy the full SHA 2059084View commit details -
Signed-off-by: Shahriar Shatil <52494840+ShatilKhan@users.noreply.github.com> Signed-off-by: ShatilKhan <shatilshahriar009@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for 24b3d37 - Browse repository at this point
Copy the full SHA 24b3d37View commit details -
Signed-off-by: Shahriar Shatil <52494840+ShatilKhan@users.noreply.github.com> Signed-off-by: ShatilKhan <shatilshahriar009@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for 35d11f2 - Browse repository at this point
Copy the full SHA 35d11f2View commit details -
On line 88, in order to optimize We perform the subtraction within the map-get function directly. This simplifies the calculation by removing the unnecessary parentheses around map-get($map, 'percentage'). Signed-off-by: Shahriar Shatil <52494840+ShatilKhan@users.noreply.github.com> Signed-off-by: ShatilKhan <shatilshahriar009@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for 3b0ef5d - Browse repository at this point
Copy the full SHA 3b0ef5dView commit details -
Signed-off-by: Shahriar Shatil <52494840+ShatilKhan@users.noreply.github.com> Signed-off-by: ShatilKhan <shatilshahriar009@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for c744b56 - Browse repository at this point
Copy the full SHA c744b56View commit details -
Signed-off-by: Shahriar Shatil <52494840+ShatilKhan@users.noreply.github.com> Signed-off-by: ShatilKhan <shatilshahriar009@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for b9d2042 - Browse repository at this point
Copy the full SHA b9d2042View commit details -
Signed-off-by: Shahriar Shatil <52494840+ShatilKhan@users.noreply.github.com> Signed-off-by: ShatilKhan <shatilshahriar009@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for 2a23689 - Browse repository at this point
Copy the full SHA 2a23689View commit details -
Signed-off-by: ShatilKhan <shatilshahriar009@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for 7d3c3f5 - Browse repository at this point
Copy the full SHA 7d3c3f5View commit details -
Signed-off-by: ShatilKhan <shatilshahriar009@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for 9814449 - Browse repository at this point
Copy the full SHA 9814449View commit details -
Signed-off-by: Shahriar Shatil <52494840+ShatilKhan@users.noreply.github.com> Signed-off-by: ShatilKhan <shatilshahriar009@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for 2aee718 - Browse repository at this point
Copy the full SHA 2aee718View commit details -
Signed-off-by: Shahriar Shatil <52494840+ShatilKhan@users.noreply.github.com> Signed-off-by: ShatilKhan <shatilshahriar009@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for c387876 - Browse repository at this point
Copy the full SHA c387876View commit details
Commits on Dec 11, 2023
-
Signed-off-by: Shahriar Shatil <52494840+ShatilKhan@users.noreply.github.com>
Configuration menu - View commit details
-
Copy full SHA for 9cc2a25 - Browse repository at this point
Copy the full SHA 9cc2a25View commit details
Commits on Jan 5, 2024
-
Signed-off-by: Shahriar Shatil <52494840+ShatilKhan@users.noreply.github.com>
Configuration menu - View commit details
-
Copy full SHA for c69648e - Browse repository at this point
Copy the full SHA c69648eView commit details -
Signed-off-by: Shahriar Shatil <52494840+ShatilKhan@users.noreply.github.com>
Configuration menu - View commit details
-
Copy full SHA for 0f5542f - Browse repository at this point
Copy the full SHA 0f5542fView commit details
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.