Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Optimize calc() usage in scss files #1158

Open
wants to merge 17 commits into
base: main
Choose a base branch
from
Open

Optimize calc() usage in scss files #1158

wants to merge 17 commits into from

Commits on Nov 16, 2023

  1. Update README.md (opensearch-project#570) 

    Signed-off-by: Nuraiym Omurbekova <nuraikaomurbek@gmail.com>
Co-authored-by: Josh Romero <rmerqg@amazon.com>
Signed-off-by: ShatilKhan <shatilshahriar009@gmail.com>
    @Naurabay @joshuarrrr @ShatilKhan
    2 people authored and ShatilKhan committed Nov 16, 2023
    Configuration menu
    Copy the full SHA
    1dcc096 View commit details
    Browse the repository at this point in the history

Commits on Nov 17, 2023

  1. Replace node-sass with sass-embedded (opensearch-project#1001) 

    Also:
* Implement sass variable extraction
* Implement sass variable importing in typescript
* Add guards to post-install cleanup
* Make sources compatible with dart sass by wrapping divisions in `calc()` and adding units were necessary
* Fold in `@elastic/charts/dist/theme.scss` to modify it for dart-sass compatibility
* Break out compiling `charts`

Signed-off-by: Miki <miki@amazon.com>
Signed-off-by: ShatilKhan <shatilshahriar009@gmail.com>
    @AMoo-Miki @ShatilKhan
    AMoo-Miki authored and ShatilKhan committed Nov 17, 2023
    Configuration menu
    Copy the full SHA
    150eb7d View commit details
    Browse the repository at this point in the history

  2. Bump typescript to 4.6.4 (opensearch-project#879) 

    * typescript bump: 4.1.6

Signed-off-by: Danila Gulderov <danila@gulderov.me>

* typescript bump: 4.2.4

Signed-off-by: Danila Gulderov <danila@gulderov.me>

* typescript bump: 4.3.5

Signed-off-by: Danila Gulderov <danila@gulderov.me>

* typescript bump: 4.4.4

Signed-off-by: Danila Gulderov <danila@gulderov.me>

* typescript bump: 4.5.5

Signed-off-by: Danila Gulderov <danila@gulderov.me>

* typescript bump: 4.6.4

Signed-off-by: Danila Gulderov <danila@gulderov.me>

* CHANGELOG.md updated

Signed-off-by: Danila Gulderov <danila@gulderov.me>

* bump typescript-eslint/eslint-plugin: 5.62.0
bump typescript-eslint/parser: 5.62.0

node 16 is required for typescript-eslint: 6.0.0

Signed-off-by: Danila Gulderov <danila@gulderov.me>

* CHANGELOG.md update

Signed-off-by: Danila Gulderov <danila@gulderov.me>

* move typescript update to regular section

Signed-off-by: Danila Gulderov <danila@gulderov.me>

* changelog message improvement

Signed-off-by: Danila Gulderov <danila@gulderov.me>

* fix typings

Signed-off-by: Danila Gulderov <danila@gulderov.me>

* cleanup useUnknownInCatchVariables

Signed-off-by: Danila Gulderov <danila@gulderov.me>

* logical or => nullish coalescing

Signed-off-by: Danila Gulderov <danila@gulderov.me>

* wrap with String

Signed-off-by: Danila Gulderov <danila@gulderov.me>

* Update CHANGELOG.md

Move CHANGELOG entry to the unreleased section

Signed-off-by: Miki <miki@amazon.com>

* Add back `onPinClick` check in `OuiPinnableListGroup`

Update pinnable_list_group.tsx

Signed-off-by: Miki <miki@amazon.com>

* Enhance error message extraction in `validateFieldValue`

Update default_syntax.ts

Signed-off-by: Miki <miki@amazon.com>

* Remove e.code from default_syntax.ts

Update default_syntax.ts

Signed-off-by: Miki <miki@amazon.com>

* Lint default_syntax.ts

Signed-off-by: Miki <miki@amazon.com>

---------

Signed-off-by: Danila Gulderov <danila@gulderov.me>
Signed-off-by: Matt Provost <provomat@amazon.com>
Signed-off-by: Miki <miki@amazon.com>
Co-authored-by: Matt Provost <provomat@amazon.com>
Co-authored-by: Josh Romero <rmerqg@amazon.com>
Co-authored-by: Miki <miki@amazon.com>
Signed-off-by: ShatilKhan <shatilshahriar009@gmail.com>
    @gulderov @BSFishy
    @joshuarrrr @AMoo-Miki @ShatilKhan
    4 people authored and ShatilKhan committed Nov 17, 2023
    Configuration menu
    Copy the full SHA
    d07d137 View commit details
    Browse the repository at this point in the history

  3. Update _card.scss 

    Signed-off-by: Shahriar Shatil <52494840+ShatilKhan@users.noreply.github.com>
Signed-off-by: ShatilKhan <shatilshahriar009@gmail.com>
    @ShatilKhan
    ShatilKhan committed Nov 17, 2023
    Configuration menu
    Copy the full SHA
    2059084 View commit details
    Browse the repository at this point in the history

  4. Update _combo_box.scss 

    Signed-off-by: Shahriar Shatil <52494840+ShatilKhan@users.noreply.github.com>
Signed-off-by: ShatilKhan <shatilshahriar009@gmail.com>
    @ShatilKhan
    ShatilKhan committed Nov 17, 2023
    Configuration menu
    Copy the full SHA
    24b3d37 View commit details
    Browse the repository at this point in the history

  5. Update _control_bar.scss 

    Signed-off-by: Shahriar Shatil <52494840+ShatilKhan@users.noreply.github.com>
Signed-off-by: ShatilKhan <shatilshahriar009@gmail.com>
    @ShatilKhan
    ShatilKhan committed Nov 17, 2023
    Configuration menu
    Copy the full SHA
    35d11f2 View commit details
    Browse the repository at this point in the history

  6. Update _flex_grid.scss 

    On line 88, in order to optimize
We perform the subtraction within the map-get function directly.
This simplifies the calculation by removing the unnecessary parentheses around map-get($map, 'percentage').

Signed-off-by: Shahriar Shatil <52494840+ShatilKhan@users.noreply.github.com>
Signed-off-by: ShatilKhan <shatilshahriar009@gmail.com>
    @ShatilKhan
    ShatilKhan committed Nov 17, 2023
    Configuration menu
    Copy the full SHA
    3b0ef5d View commit details
    Browse the repository at this point in the history

  7. Update _tool_tip.scss 

    Signed-off-by: Shahriar Shatil <52494840+ShatilKhan@users.noreply.github.com>
Signed-off-by: ShatilKhan <shatilshahriar009@gmail.com>
    @ShatilKhan
    ShatilKhan committed Nov 17, 2023
    Configuration menu
    Copy the full SHA
    c744b56 View commit details
    Browse the repository at this point in the history

  8. Update _range_thumb.scss 

    Signed-off-by: Shahriar Shatil <52494840+ShatilKhan@users.noreply.github.com>
Signed-off-by: ShatilKhan <shatilshahriar009@gmail.com>
    @ShatilKhan
    ShatilKhan committed Nov 17, 2023
    Configuration menu
    Copy the full SHA
    b9d2042 View commit details
    Browse the repository at this point in the history

  9. Update tree_view.scss 

    Signed-off-by: Shahriar Shatil <52494840+ShatilKhan@users.noreply.github.com>
Signed-off-by: ShatilKhan <shatilshahriar009@gmail.com>
    @ShatilKhan
    ShatilKhan committed Nov 17, 2023
    Configuration menu
    Copy the full SHA
    2a23689 View commit details
    Browse the repository at this point in the history

  10. Update range_thumb.scss 

    Signed-off-by: ShatilKhan <shatilshahriar009@gmail.com>
    @ShatilKhan
    ShatilKhan committed Nov 17, 2023
    Configuration menu
    Copy the full SHA
    7d3c3f5 View commit details
    Browse the repository at this point in the history

  11. Update Changelog 

    Signed-off-by: ShatilKhan <shatilshahriar009@gmail.com>
    @ShatilKhan
    ShatilKhan committed Nov 17, 2023
    Configuration menu
    Copy the full SHA
    9814449 View commit details
    Browse the repository at this point in the history

  12. Update _range_slider.scss 

    Signed-off-by: Shahriar Shatil <52494840+ShatilKhan@users.noreply.github.com>
Signed-off-by: ShatilKhan <shatilshahriar009@gmail.com>
    @ShatilKhan
    ShatilKhan committed Nov 17, 2023
    Configuration menu
    Copy the full SHA
    2aee718 View commit details
    Browse the repository at this point in the history

  13. Update _resizable_button.scss 

    Signed-off-by: Shahriar Shatil <52494840+ShatilKhan@users.noreply.github.com>
Signed-off-by: ShatilKhan <shatilshahriar009@gmail.com>
    @ShatilKhan
    ShatilKhan committed Nov 17, 2023
    Configuration menu
    Copy the full SHA
    c387876 View commit details
    Browse the repository at this point in the history

Commits on Dec 11, 2023

  1. Merge branch 'main' into calc 

    Signed-off-by: Shahriar Shatil <52494840+ShatilKhan@users.noreply.github.com>
    @ShatilKhan
    ShatilKhan authored Dec 11, 2023
    Configuration menu
    Copy the full SHA
    9cc2a25 View commit details
    Browse the repository at this point in the history

Commits on Jan 5, 2024

  1. Update index.js 

    Signed-off-by: Shahriar Shatil <52494840+ShatilKhan@users.noreply.github.com>
    @ShatilKhan
    ShatilKhan authored Jan 5, 2024
    Configuration menu
    Copy the full SHA
    c69648e View commit details
    Browse the repository at this point in the history

  2. Merge branch 'main' into calc 

    Signed-off-by: Shahriar Shatil <52494840+ShatilKhan@users.noreply.github.com>
    @ShatilKhan
    ShatilKhan authored Jan 5, 2024
    Configuration menu
    Copy the full SHA
    0f5542f View commit details
    Browse the repository at this point in the history