Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add CSS display-none utility #1120

Merged
merged 9 commits into from
Jan 13, 2024
Merged

Add CSS display-none utility #1120

merged 9 commits into from
Jan 13, 2024

Conversation

ShatilKhan
Copy link
Contributor

Description

Added new CSS Utility Class display-none

Issues Resolved

Fixes #773

Check List

  • New functionality includes testing.
  • New functionality has been documented.
  • All tests pass
    • yarn lint
    • yarn test-unit
  • Update CHANGELOG.md
  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@ShatilKhan
Update _utility.scss
52432d3 
Signed-off-by: Shahriar Shatil <52494840+ShatilKhan@users.noreply.github.com>
@ShatilKhan
Update CHANGELOG.md
14f0fe0 
Signed-off-by: Shahriar Shatil <52494840+ShatilKhan@users.noreply.github.com>
joshuarrrr
joshuarrrr reviewed Oct 30, 2023
View reviewed changes
Copy link
Member

@joshuarrrr joshuarrrr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ShatilKhan Can you also update https://github.com/opensearch-project/oui/blob/main/src-docs/src/views/utility_classes/utility_classes.js so that the new class is listed on https://oui.opensearch.org/1.3/#/utilities/css-utility-classes

@BSFishy BSFishy added the OSCI label Nov 2, 2023
@ShatilKhan
Copy link
Contributor Author

@ShatilKhan Can you also update https://github.com/opensearch-project/oui/blob/main/src-docs/src/views/utility_classes/utility_classes.js so that the new class is listed on https://oui.opensearch.org/1.3/#/utilities/css-utility-classes

Yeah I'll update it today

@joshuarrrr
Copy link
Member

@ShatilKhan Just checking back to see if you'll be able to finish up this PR.

@ShatilKhan
Copy link
Contributor Author

Yeah @joshuarrrr
I'm finishing up all my PRs by next week hopefully
Was busy with studies for the past few weeks, hence wasn't able to contribute

@ShatilKhan
Add oui-displayNone to utility_classes.js
095c857 
Signed-off-by: Shahriar Shatil <52494840+ShatilKhan@users.noreply.github.com>
@ShatilKhan
Copy link
Contributor Author

@ShatilKhan Can you also update https://github.com/opensearch-project/oui/blob/main/src-docs/src/views/utility_classes/utility_classes.js so that the new class is listed on https://oui.opensearch.org/1.3/#/utilities/css-utility-classes

Done with this one

joshuarrrr
joshuarrrr reviewed Dec 11, 2023
View reviewed changes
Copy link
Member

@joshuarrrr joshuarrrr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @ShatilKhan! Just a few minor formatting tweaks.

src-docs/src/views/utility_classes/utility_classes.js Outdated Show resolved Hide resolved
src-docs/src/views/utility_classes/utility_classes.js Outdated Show resolved Hide resolved
src-docs/src/views/utility_classes/utility_classes.js Outdated Show resolved Hide resolved
ShatilKhan and others added 3 commits December 12, 2023 06:09
@ShatilKhan @joshuarrrr
Update utility_classes.js
65fcb14 
Co-authored-by: Josh Romero <rmerqg@amazon.com>
Signed-off-by: Shahriar Shatil <52494840+ShatilKhan@users.noreply.github.com>
@ShatilKhan @joshuarrrr
Fix typo in utility_classes.js
d4087b5 
Co-authored-by: Josh Romero <rmerqg@amazon.com>
Signed-off-by: Shahriar Shatil <52494840+ShatilKhan@users.noreply.github.com>
@ShatilKhan @joshuarrrr
Fix Indentation in utility_classes.js
6af59b2 
Co-authored-by: Josh Romero <rmerqg@amazon.com>
Signed-off-by: Shahriar Shatil <52494840+ShatilKhan@users.noreply.github.com>
@ShatilKhan
Copy link
Contributor Author

ShatilKhan commented Dec 12, 2023 •
edited
Loading

Done with the suggested changes

@ShatilKhan
Merge branch 'main' into dispnone
af58544 
Signed-off-by: Shahriar Shatil <52494840+ShatilKhan@users.noreply.github.com>
joshuarrrr
joshuarrrr previously approved these changes Dec 12, 2023
View reviewed changes
@BSFishy
Copy link
Contributor

BSFishy commented Dec 12, 2023

This linting error should be fixed: https://github.com/opensearch-project/oui/actions/runs/7175077016/job/19539863193?pr=1120#step:5:17

@joshuarrrr joshuarrrr dismissed their stale review December 12, 2023 17:09

awaiting linting fix

@ShatilKhan
fix lint
1a69c98 
Signed-off-by: Shahriar Shatil <52494840+ShatilKhan@users.noreply.github.com>
ShatilKhan
ShatilKhan commented Dec 13, 2023
View reviewed changes
Copy link
Contributor Author

@ShatilKhan ShatilKhan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed linting problem on line 104 in utility_classes.js

BSFishy
BSFishy reviewed Jan 2, 2024
View reviewed changes
Copy link
Contributor

@BSFishy BSFishy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I just realized this should also be added to src/themes/oui-next/global_styling/utility/_utility.scss so it works in next themes as well

@ShatilKhan
Add displayNone to oui-next
3cd2a76 
Signed-off-by: Shahriar Shatil <52494840+ShatilKhan@users.noreply.github.com>
@ShatilKhan
Copy link
Contributor Author

I just realized this should also be added to src/themes/oui-next/global_styling/utility/_utility.scss so it works in next themes as well

done

@joshuarrrr joshuarrrr merged commit 5e7ac43 into opensearch-project:main Jan 13, 2024
16 checks passed
opensearch-trigger-bot bot pushed a commit that referenced this pull request Jan 13, 2024
@github-actions
Add CSS display-none utility (#1120)
7beea00 
* Update _utility.scss

Signed-off-by: Shahriar Shatil <52494840+ShatilKhan@users.noreply.github.com>

* Update CHANGELOG.md

Signed-off-by: Shahriar Shatil <52494840+ShatilKhan@users.noreply.github.com>

* Add `oui-displayNone` to `utility_classes.js`

Signed-off-by: Shahriar Shatil <52494840+ShatilKhan@users.noreply.github.com>

* Update utility_classes.js

Co-authored-by: Josh Romero <rmerqg@amazon.com>
Signed-off-by: Shahriar Shatil <52494840+ShatilKhan@users.noreply.github.com>

* Fix typo in utility_classes.js

Co-authored-by: Josh Romero <rmerqg@amazon.com>
Signed-off-by: Shahriar Shatil <52494840+ShatilKhan@users.noreply.github.com>

* Fix Indentation in utility_classes.js

Co-authored-by: Josh Romero <rmerqg@amazon.com>
Signed-off-by: Shahriar Shatil <52494840+ShatilKhan@users.noreply.github.com>

* fix lint

Signed-off-by: Shahriar Shatil <52494840+ShatilKhan@users.noreply.github.com>

* Add displayNone to oui-next

Signed-off-by: Shahriar Shatil <52494840+ShatilKhan@users.noreply.github.com>

---------

Signed-off-by: Shahriar Shatil <52494840+ShatilKhan@users.noreply.github.com>
Co-authored-by: Josh Romero <rmerqg@amazon.com>
(cherry picked from commit 5e7ac43)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>

# Conflicts:
#	CHANGELOG.md
@opensearch-trigger-bot opensearch-trigger-bot bot mentioned this pull request Jan 13, 2024
Merged
BSFishy pushed a commit that referenced this pull request Jan 25, 2024
@opensearch-trigger-bot @github-actions
Add CSS display-none utility (#1120) (#1210)
b88b1e7 
* Update _utility.scss

Signed-off-by: Shahriar Shatil <52494840+ShatilKhan@users.noreply.github.com>

* Update CHANGELOG.md

Signed-off-by: Shahriar Shatil <52494840+ShatilKhan@users.noreply.github.com>

* Add `oui-displayNone` to `utility_classes.js`

Signed-off-by: Shahriar Shatil <52494840+ShatilKhan@users.noreply.github.com>

* Update utility_classes.js

Co-authored-by: Josh Romero <rmerqg@amazon.com>
Signed-off-by: Shahriar Shatil <52494840+ShatilKhan@users.noreply.github.com>

* Fix typo in utility_classes.js

Co-authored-by: Josh Romero <rmerqg@amazon.com>
Signed-off-by: Shahriar Shatil <52494840+ShatilKhan@users.noreply.github.com>

* Fix Indentation in utility_classes.js

Co-authored-by: Josh Romero <rmerqg@amazon.com>
Signed-off-by: Shahriar Shatil <52494840+ShatilKhan@users.noreply.github.com>

* fix lint

Signed-off-by: Shahriar Shatil <52494840+ShatilKhan@users.noreply.github.com>

* Add displayNone to oui-next

Signed-off-by: Shahriar Shatil <52494840+ShatilKhan@users.noreply.github.com>

---------

Signed-off-by: Shahriar Shatil <52494840+ShatilKhan@users.noreply.github.com>
Co-authored-by: Josh Romero <rmerqg@amazon.com>
(cherry picked from commit 5e7ac43)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>

# Conflicts:
#	CHANGELOG.md

Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@BSFishy BSFishy BSFishy approved these changes

@ashwin-pc ashwin-pc ashwin-pc approved these changes

@joshuarrrr joshuarrrr joshuarrrr left review comments

@seanneumann seanneumann Awaiting requested review from seanneumann

@AMoo-Miki AMoo-Miki Awaiting requested review from AMoo-Miki AMoo-Miki is a code owner

@rednaksi91 rednaksi91 Awaiting requested review from rednaksi91

@KrooshalUX KrooshalUX Awaiting requested review from KrooshalUX

@bandinib-amzn bandinib-amzn Awaiting requested review from bandinib-amzn bandinib-amzn is a code owner

@andreymyssak andreymyssak Awaiting requested review from andreymyssak

@SergeyMyssak SergeyMyssak Awaiting requested review from SergeyMyssak

Assignees
No one assigned
Labels
backport 1.x first-time-contributor OSCI
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add oui-displayNone CSS utility
4 participants
@ShatilKhan @joshuarrrr @BSFishy @ashwin-pc