Fix alignment of left icon for OuiListGroupItem #1027
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…pensearch-project#1000) Signed-off-by: Danila Gulderov <danila@gulderov.me>
gulderov
requested review from
seanneumann,
AMoo-Miki,
rednaksi91,
KrooshalUX,
BSFishy,
bandinib-amzn,
ashwin-pc,
joshuarrrr,
andreymyssak and
SergeyMyssak
as code owners
Signed-off-by: Danila Gulderov <danila@gulderov.me>
|
@KrooshalUX please let me know if it is desired fix Link to live demo: https://oui-three.vercel.app/#/display/list-group#text-wrapping-and-tooltips |
|
@kgcreative Can you review from the UX side (or is there someone else who should review)? |
|
LGTM -- this is a really nice update |
|
@canascar -- can you update the figma component to match? |
BSFishy
approved these changes
Sep 11, 2023
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Sep 12, 2023
* Fix alignment of left icon for OuiListGroupItem with multiline text (#1000) Signed-off-by: Danila Gulderov <danila@gulderov.me> * Changelog update (#1000) Signed-off-by: Danila Gulderov <danila@gulderov.me> --------- Signed-off-by: Danila Gulderov <danila@gulderov.me> (cherry picked from commit 17db63c) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> # Conflicts: # CHANGELOG.md
joshuarrrr
pushed a commit
that referenced
this pull request
Sep 12, 2023
* Fix alignment of left icon for OuiListGroupItem with multiline text (#1000) Signed-off-by: Danila Gulderov <danila@gulderov.me> * Changelog update (#1000) Signed-off-by: Danila Gulderov <danila@gulderov.me> --------- Signed-off-by: Danila Gulderov <danila@gulderov.me> (cherry picked from commit 17db63c) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> # Conflicts: # CHANGELOG.md Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fix alignment of left icon for OuiListGroupItem with multiline text
Before:
After:
Issues Resolved
Fixes #1000
Check List
yarn lintyarn test-unitBy submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.