-
Notifications
You must be signed in to change notification settings - Fork 70
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix alignment of left icon for OuiListGroupItem #1027
Fix alignment of left icon for OuiListGroupItem #1027
Conversation
…pensearch-project#1000) Signed-off-by: Danila Gulderov <danila@gulderov.me>
Signed-off-by: Danila Gulderov <danila@gulderov.me>
@KrooshalUX please let me know if it is desired fix Link to live demo: https://oui-three.vercel.app/#/display/list-group#text-wrapping-and-tooltips |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
@kgcreative Can you review from the UX side (or is there someone else who should review)? |
LGTM -- this is a really nice update |
@canascar -- can you update the figma component to match? |
* Fix alignment of left icon for OuiListGroupItem with multiline text (#1000) Signed-off-by: Danila Gulderov <danila@gulderov.me> * Changelog update (#1000) Signed-off-by: Danila Gulderov <danila@gulderov.me> --------- Signed-off-by: Danila Gulderov <danila@gulderov.me> (cherry picked from commit 17db63c) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> # Conflicts: # CHANGELOG.md
* Fix alignment of left icon for OuiListGroupItem with multiline text (#1000) Signed-off-by: Danila Gulderov <danila@gulderov.me> * Changelog update (#1000) Signed-off-by: Danila Gulderov <danila@gulderov.me> --------- Signed-off-by: Danila Gulderov <danila@gulderov.me> (cherry picked from commit 17db63c) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> # Conflicts: # CHANGELOG.md Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Description
Fix alignment of left icon for OuiListGroupItem with multiline text
Before:
After:
Issues Resolved
Fixes #1000
Check List
yarn lint
yarn test-unit
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.