Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Feature Request] Vertical button group #659

Open
ruanyl opened this issue Apr 4, 2023 · 5 comments
Open

[Feature Request] Vertical button group #659

ruanyl opened this issue Apr 4, 2023 · 5 comments
Labels
Component Iteration enhancement New feature or request ux/ui

Comments

@ruanyl
Copy link
Member

ruanyl commented Apr 4, 2023

Is your feature request related to a problem? Please describe.

Trying to add vertical button group similar to this, but couldn't find it's supported from the doc.
image

Describe the solution you'd like

I'd like to have ButtonGroup component to also support vertical alignment. I can see material-ui have something similar.

Describe alternatives you've considered

We can use custom css styles but it would be nice if OUI can support this natively.

Additional context

dashboards-maps project needs to add a map control button group like this:
image

The PR: opensearch-project/dashboards-maps#372
cc @VijayanB @junqiu-lei
@ruanyl ruanyl added the enhancement New feature or request label Apr 4, 2023
@KrooshalUX
Copy link
Contributor

@ruanyl thanks for your feature request - I think this proposal makes sense to iterate on OuiButtonGroup and add an orientation prop which should give you what you need for the short term, while we work on a more comprehensive Actions Bar design on the UX side.

(cc @BSFishy apologies - your initial tag "component iteration" was correct - I misunderstood and thought that Maps team was already aware of the Action Bar designs and was making a request for that. )

@KrooshalUX KrooshalUX mentioned this issue Apr 10, 2023
Open
4 tasks
@KrooshalUX
Copy link
Contributor

@ruanyl do you want to contribute this change?

@ruanyl
Copy link
Member Author

ruanyl commented Apr 13, 2023

@KrooshalUX Sure, l'd love to 😃 I will get it planned and work on it

ruanyl added a commit to ruanyl/oui that referenced this issue May 10, 2023
@ruanyl
feat: vertical oriented button group
4e99349 
This commit added a new prop(orientation) to the current OuiButtonGroup,
the possible values are `horizontal` and `vertical`. The default value
is `horizontal` which match the current UI behavior. With `vertical`
prop, the button group will be oriented vertically.

related issue: opensearch-project#659

Signed-off-by: Yulong Ruan <ruanyl@amazon.com>
@ruanyl ruanyl mentioned this issue May 10, 2023
Draft
6 tasks
@keskami
Copy link
Contributor

keskami commented Oct 26, 2023

@joshuarrrr I can take this issue if no one is working on it at the moment!

@joshuarrrr
Copy link
Member

@keskami It looks like there's already a draft PR for it: #755

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Component Iteration enhancement New feature or request ux/ui
Projects
Look & Feel
Status: Todo
Milestone
No milestone
Development

No branches or pull requests
5 participants
@ruanyl @joshuarrrr @BSFishy @keskami @KrooshalUX