Correct the nginx proxy port in .env #103
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`NGINX_ADDR=nginx:${FRONTEND_ADDR}` shoud be `NGINX_ADDR=nginx:${NGINX_PORT}`.
Signed-off-by: gaobinlong <gbinlong@amazon.com>
gaobinlong
requested review from
pjfitzgibbons,
ps48,
kavithacm,
derek-ho,
joshuali925,
dai-chen,
YANG-DB,
rupal-bq,
mengweieric,
vamsi-amazon and
Swiddis
as code owners
|
Could anyone help to review this PR? All requests from load-generator are failed because of the bug. |
|
This PR was marked stale due to lack of activity. It will be closed in 7 days. |
|
@YANG-DB could you help to review this PR? |
YANG-DB
approved these changes
Nov 29, 2023
|
thanks @gaobinlong |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
NGINX_ADDR=nginx:${FRONTEND_ADDR}shoud beNGINX_ADDR=nginx:${NGINX_PORT}.Changes
Please provide a brief description of the changes here.
Merge Requirements
For new features contributions please make sure you have completed the following
essential items:
CHANGELOG.mdupdated to document new feature additionsMaintainers will not merge until the above have been completed. If you're unsure
which docs need to be changed ping the
@open-telemetry/demo-approvers.