Add PPL Between functionality #758
Open
+165
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
hi @dr-lilienthal |
|
@dr-lilienthal
|
salyh
force-pushed
the
between
branch
3 times, most recently
from
75e8dd4
to
6c13c69
Compare
dr-lilienthal
requested review from
dai-chen,
rupal-bq,
vamsi-amazon,
penghuo,
seankao-az,
anirudha,
kaituo,
YANG-DB and
LantaoJin
as code owners
dr-lilienthal
force-pushed
the
between
branch
2 times, most recently
from
1d82270
to
1622e1e
Compare
YANG-DB
approved these changes
Oct 17, 2024
YANG-DB
requested changes
Oct 17, 2024
...cala/org/opensearch/flint/spark/ppl/PPLLogicalPlanBetweenExpressionTranslatorTestSuite.scala
Outdated
Show resolved
Hide resolved
YANG-DB
approved these changes
Oct 24, 2024
Signed-off-by: Hendrik Saly <hendrik.saly@eliatra.com>
Signed-off-by: Jens Schmidt <jens.schmidt@eliatra.com>
Signed-off-by: Hendrik Saly <hendrik.saly@eliatra.com>
Signed-off-by: Jens Schmidt <jens.schmidt@eliatra.com>
Signed-off-by: Jens Schmidt <jens.schmidt@eliatra.com>
Signed-off-by: Jens Schmidt <jens.schmidt@eliatra.com>
Signed-off-by: Jens Schmidt <jens.schmidt@eliatra.com>
salyh
requested review from
mengweieric,
noCharger and
ykmr1224
as code owners
LantaoJin
reviewed
Oct 25, 2024
| @@ -371,6 +371,7 @@ logicalExpression | |||
| | left = logicalExpression OR right = logicalExpression # logicalOr | |||
| | left = logicalExpression XOR right = logicalExpression # logicalXor | |||
| | booleanExpression # booleanExpr | |||
| | expr1 = functionArg NOT? BETWEEN expr2 = functionArg AND expr3 = functionArg # between | |||
There was a problem hiding this comment.
Move this new expression under booleanExpression
| @@ -368,6 +368,7 @@ LIKE: 'LIKE'; | |||
| ISNULL: 'ISNULL'; | |||
| ISNOTNULL: 'ISNOTNULL'; | |||
| ISPRESENT: 'ISPRESENT'; | |||
| BETWEEN: 'BETWEEN'; | |||
There was a problem hiding this comment.
Add BETWEEN to keywordsCanBeId
| @@ -49,6 +49,8 @@ _- **Limitation: new field added by eval command with a function cannot be dropp | |||
| - `source = table | where isempty(a)` | |||
| - `source = table | where isblank(a)` | |||
| - `source = table | where case(length(a) > 6, 'True' else 'False') = 'True'` | |||
| - `source = table | where a between 1 and 4` | |||
There was a problem hiding this comment.
I think we need explain the range of between is [1, 4] rather than (1, 4) in user doc. From the code implementation, I think it is [1, 4]. In anther word, when a = 1, the predicate returns True
| }) | ||
| } | ||
|
|
||
| test("test between should return records NOT between two values") { |
There was a problem hiding this comment.
Can you add two tests (between and not between) with Date/Time in condition?
I think you can use the table by createTimeSeriesTable
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add PPL Between functionality
Issues Resolved
#679
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.